Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp

Issue 1866623002: Hook up CSSPaintValue::image to CSS Paint API callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments + rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
diff --git a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
index 339962f6cd6147786d9d8736a493e3331167b866..02835412b47b2897d9f45925329a2b22236970d7 100644
--- a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
+++ b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
@@ -5,6 +5,15 @@
#include "modules/csspaint/CSSPaintDefinition.h"
#include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8BindingMacros.h"
+#include "bindings/core/v8/V8ObjectConstructor.h"
+#include "core/dom/ExecutionContext.h"
+#include "modules/csspaint/Geometry.h"
+#include "modules/csspaint/PaintRenderingContext2D.h"
+#include "platform/graphics/ImageBuffer.h"
+#include "platform/graphics/PaintGeneratedImage.h"
+#include "platform/graphics/RecordingImageBufferSurface.h"
namespace blink {
@@ -24,4 +33,62 @@ CSSPaintDefinition::~CSSPaintDefinition()
{
}
+PassRefPtr<Image> CSSPaintDefinition::paint(const IntSize& size)
+{
+ ScriptState::Scope scope(m_scriptState.get());
+
+ maybeCreatePaintInstance();
+
+ v8::Isolate* isolate = m_scriptState->isolate();
+ v8::Local<v8::Object> instance = m_instance.newLocal(isolate);
+
+ // We may have failed to create an instance class, in which case produce an
+ // invalid image.
+ if (isUndefinedOrNull(instance))
+ return nullptr;
+
+ PaintRenderingContext2D* renderingContext = PaintRenderingContext2D::create(
+ ImageBuffer::create(adoptPtr(new RecordingImageBufferSurface(size))));
+ Geometry* geometry = Geometry::create(size);
+
+ v8::Local<v8::Value> argv[] = {
+ toV8(renderingContext, m_scriptState->context()->Global(), isolate),
+ toV8(geometry, m_scriptState->context()->Global(), isolate)
+ };
+
+ v8::Local<v8::Function> paint = m_paint.newLocal(isolate);
+
+ v8::TryCatch block(isolate);
+ block.SetVerbose(true);
+
+ V8ScriptRunner::callFunction(paint, m_scriptState->getExecutionContext(), instance, 2, argv, isolate);
+
+ // The paint function may have produced an error, in which case produce an
+ // invalid image.
+ if (block.HasCaught()) {
+ return nullptr;
+ }
+
+ return PaintGeneratedImage::create(renderingContext->imageBuffer()->getPicture(), size);
+}
+
+void CSSPaintDefinition::maybeCreatePaintInstance()
+{
+ if (m_didCallConstructor)
+ return;
+
+ DCHECK(m_instance.isEmpty());
+
+ v8::Isolate* isolate = m_scriptState->isolate();
+ v8::Local<v8::Function> constructor = m_constructor.newLocal(isolate);
+ DCHECK(!isUndefinedOrNull(constructor));
+
+ v8::Local<v8::Object> paintInstance;
+ if (V8ObjectConstructor::newInstance(isolate, constructor).ToLocal(&paintInstance)) {
+ m_instance.set(isolate, paintInstance);
+ }
+
+ m_didCallConstructor = true;
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698