Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1866533002: Remove unreferenced local variable which breaks build. (Closed)

Created:
4 years, 8 months ago by yxma
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unreferenced local variable which breaks build. Depending on compiler's setting, the unreferenced local variable may cause build break. modified: src/processor/minidump.cc R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/32901f6d4ceb9c2ba0e216e4ffdfd6f9dceabb9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/processor/minidump.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yxma
4 years, 8 months ago (2016-04-05 23:23:01 UTC) #2
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-05 23:31:22 UTC) #3
Mark Mentovai
4 years, 8 months ago (2016-04-05 23:37:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32901f6d4ceb9c2ba0e216e4ffdfd6f9dceabb9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698