Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1866523002: [Mac] Update location bar colors when change themes in Material Design. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Update location bar colors when change themes in Material Design. Incognito windows show a dark location bar when using the system theme and a regular (white) location bar when using a custom theme. This cl allows an Incognito window's location bar to switch between dark and regular modes as the user changes themes. R=avi@chromium.org BUG=595033 Committed: https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513 Cr-Commit-Position: refs/heads/master@{#385780}

Patch Set 1 #

Patch Set 2 : Clean up for review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -34 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 4 chunks +29 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 2 chunks +41 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 1 chunk +19 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-06 23:11:00 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-07 01:52:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866523002/20001
4 years, 8 months ago (2016-04-07 15:55:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 16:33:20 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:34:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b490b0d0e249b36bc21274a69585dfec4e04e513
Cr-Commit-Position: refs/heads/master@{#385780}

Powered by Google App Engine
This is Rietveld 408576698