Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1611)

Unified Diff: net/spdy/spdy_http_utils_unittest.cc

Issue 1866483002: Add a new priority level, THROTTLED, below IDLE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_http_utils_unittest.cc
diff --git a/net/spdy/spdy_http_utils_unittest.cc b/net/spdy/spdy_http_utils_unittest.cc
index a53e33145d284af138f07456e408f89e8fa44420..29cb5b46b7dd83b5e1a7c2396b19e571ecf6de4e 100644
--- a/net/spdy/spdy_http_utils_unittest.cc
+++ b/net/spdy/spdy_http_utils_unittest.cc
@@ -27,6 +27,7 @@ TEST(SpdyHttpUtilsTest, ConvertRequestPriorityToSpdy3Priority) {
EXPECT_EQ(2, ConvertRequestPriorityToSpdyPriority(LOW, SPDY3));
EXPECT_EQ(3, ConvertRequestPriorityToSpdyPriority(LOWEST, SPDY3));
EXPECT_EQ(4, ConvertRequestPriorityToSpdyPriority(IDLE, SPDY3));
+ EXPECT_EQ(5, ConvertRequestPriorityToSpdyPriority(THROTTLED, SPDY3));
}
TEST(SpdyHttpUtilsTest, ConvertSpdy3PriorityToRequestPriority) {
@@ -35,9 +36,10 @@ TEST(SpdyHttpUtilsTest, ConvertSpdy3PriorityToRequestPriority) {
EXPECT_EQ(LOW, ConvertSpdyPriorityToRequestPriority(2, SPDY3));
EXPECT_EQ(LOWEST, ConvertSpdyPriorityToRequestPriority(3, SPDY3));
EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(4, SPDY3));
+ EXPECT_EQ(THROTTLED, ConvertSpdyPriorityToRequestPriority(5, SPDY3));
// These are invalid values, but we should still handle them
// gracefully.
- for (int i = 5; i < std::numeric_limits<uint8_t>::max(); ++i) {
+ for (int i = 6; i < std::numeric_limits<uint8_t>::max(); ++i) {
EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(i, SPDY3));
}
}

Powered by Google App Engine
This is Rietveld 408576698