Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1866473002: Define HAS_FEATURE instead of __has_feature (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define HAS_FEATURE instead of __has_feature As discussed in: https://codereview.chromium.org/1837563002/ The approach is what's recommended by clang and is safe because __has_feature was only defined if the compiler didn't provide it, but nonetheless it's good to be consistent. R=thakis@chromium.org Committed: https://crrev.com/a8dc9dd8ca283435a6a312918f0526300c91e8de Cr-Commit-Position: refs/heads/master@{#385541}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep Mac as-is. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M base/bit_cast.h View 1 chunk +1 line, -1 line 0 comments Download
M base/compiler_specific.h View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JF
4 years, 8 months ago (2016-04-05 21:48:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866473002/1
4 years, 8 months ago (2016-04-05 21:50:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 23:39:25 UTC) #5
Nico
thanks! lgtm with the _mac file reverted https://codereview.chromium.org/1866473002/diff/1/base/message_loop/message_pump_mac.h File base/message_loop/message_pump_mac.h (right): https://codereview.chromium.org/1866473002/diff/1/base/message_loop/message_pump_mac.h#newcode76 base/message_loop/message_pump_mac.h:76: #if !defined(__OBJC__) ...
4 years, 8 months ago (2016-04-06 00:38:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866473002/20001
4 years, 8 months ago (2016-04-06 16:43:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 20:20:42 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:22:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8dc9dd8ca283435a6a312918f0526300c91e8de
Cr-Commit-Position: refs/heads/master@{#385541}

Powered by Google App Engine
This is Rietveld 408576698