Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 186643004: Revert 254791 "Disable HostDriven_SyncTest.testDisableAndEnableSync" (Closed)

Created:
6 years, 9 months ago by tim (not reviewing)
Modified:
6 years, 9 months ago
Reviewers:
nyquist, boliu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 254791 "Disable HostDriven_SyncTest.testDisableAndEnableSync" > Disable HostDriven_SyncTest.testDisableAndEnableSync > > BUG=348951 > NOTRY=true > > Review URL: https://codereview.chromium.org/180273024 NOTRY=true R=boliu@chromium.org, nyquist@chromium.org TBR=nyquist@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M trunk/src/chrome/android/host_driven_tests/SyncTest.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tim (not reviewing)
6 years, 9 months ago (2014-03-04 20:36:04 UTC) #1
tim (not reviewing)
(Didn't TBR this, lmk if this is the right thing to do. I reverted the ...
6 years, 9 months ago (2014-03-04 20:37:43 UTC) #2
boliu
On 2014/03/04 20:37:43, timsteele wrote: > (Didn't TBR this, lmk if this is the right ...
6 years, 9 months ago (2014-03-04 20:40:55 UTC) #3
tim (not reviewing)
The CQ bit was checked by tim@chromium.org
6 years, 9 months ago (2014-03-04 20:49:08 UTC) #4
boliu
Oh I'm not an owner here. +nyquist for that
6 years, 9 months ago (2014-03-04 21:30:46 UTC) #5
tim (not reviewing)
The CQ bit was unchecked by tim@chromium.org
6 years, 9 months ago (2014-03-05 00:43:12 UTC) #6
tim (not reviewing)
The CQ bit was checked by tim@chromium.org
6 years, 9 months ago (2014-03-05 00:43:13 UTC) #7
nyquist
lgtm
6 years, 9 months ago (2014-03-05 00:45:28 UTC) #8
Sergey Berezin
On 2014/03/05 00:45:28, nyquist wrote: > lgtm FYI, the base URL is not recognized by ...
6 years, 9 months ago (2014-03-05 19:03:53 UTC) #9
tim (not reviewing)
Committed patchset #1 manually as r255168 (presubmit successful).
6 years, 9 months ago (2014-03-05 22:49:53 UTC) #10
tim (not reviewing)
6 years, 9 months ago (2014-03-05 22:50:21 UTC) #11
Message was sent while issue was closed.
On 2014/03/05 19:03:53, Sergey Berezin wrote:
> On 2014/03/05 00:45:28, nyquist wrote:
> > lgtm
> 
> FYI, the base URL is not recognized by the commit bot. You may consider
> committing manually.
> 
> Was this CL created automatically by hitting the "Revert Patchset" button? If
> so, it must be a bug in Rietveld, since the base URL of the original CL is
> valid.

No, I used drover --revert...

Powered by Google App Engine
This is Rietveld 408576698