Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 1866403005: Fix rtl shelf overflow bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small review fixes (and merge) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/overflow_bubble_view.cc ('k') | ash/test/overflow_bubble_view_test_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index 11783aea96f97525619616e03e2d13f7b9f5e714..e8572f2a5473868876ce0fefd3af851de4ad23c6 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -46,6 +46,7 @@
#include "ui/events/event_utils.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/point.h"
+#include "ui/views/bubble/bubble_frame_view.h"
#include "ui/views/view_model.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
@@ -983,7 +984,7 @@ TEST_F(ShelfViewTest, AssertNoButtonsOverlap) {
}
// Making sure the overflow bubble arrow correctly tracks with shelf position.
-TEST_F(ShelfViewTest, OverflowArrowForShelfPosition) {
+TEST_P(ShelfViewTextDirectionTest, OverflowArrowForShelfPosition) {
const wm::ShelfAlignment kAlignments[] = {
wm::SHELF_ALIGNMENT_BOTTOM, wm::SHELF_ALIGNMENT_LEFT,
wm::SHELF_ALIGNMENT_RIGHT, wm::SHELF_ALIGNMENT_BOTTOM_LOCKED,
@@ -1005,7 +1006,11 @@ TEST_F(ShelfViewTest, OverflowArrowForShelfPosition) {
ASSERT_TRUE(test_api_->overflow_bubble() &&
test_api_->overflow_bubble()->IsShowing());
- EXPECT_EQ(test_api_->overflow_bubble()->bubble_view()->arrow(), kArrows[i]);
+ EXPECT_EQ(kArrows[i], test_api_->overflow_bubble()->bubble_view()->arrow());
+ OverflowBubbleViewTestAPI bubble_view_api(
+ test_api_->overflow_bubble()->bubble_view());
+ EXPECT_EQ(kArrows[i],
+ bubble_view_api.GetBubbleFrameView()->bubble_border()->arrow());
}
}
« no previous file with comments | « ash/shelf/overflow_bubble_view.cc ('k') | ash/test/overflow_bubble_view_test_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698