Chromium Code Reviews| Index: ash/shelf/shelf_view_unittest.cc |
| diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc |
| index 11783aea96f97525619616e03e2d13f7b9f5e714..ee829dcc69556e0a0c505cc8244a2a2af588a24b 100644 |
| --- a/ash/shelf/shelf_view_unittest.cc |
| +++ b/ash/shelf/shelf_view_unittest.cc |
| @@ -46,6 +46,7 @@ |
| #include "ui/events/event_utils.h" |
| #include "ui/events/test/event_generator.h" |
| #include "ui/gfx/geometry/point.h" |
| +#include "ui/views/bubble/bubble_frame_view.h" |
| #include "ui/views/view_model.h" |
| #include "ui/views/widget/widget.h" |
| #include "ui/views/widget/widget_delegate.h" |
| @@ -983,7 +984,7 @@ TEST_F(ShelfViewTest, AssertNoButtonsOverlap) { |
| } |
| // Making sure the overflow bubble arrow correctly tracks with shelf position. |
| -TEST_F(ShelfViewTest, OverflowArrowForShelfPosition) { |
| +TEST_P(ShelfViewTextDirectionTest, OverflowArrowForShelfPosition) { |
| const wm::ShelfAlignment kAlignments[] = { |
| wm::SHELF_ALIGNMENT_BOTTOM, wm::SHELF_ALIGNMENT_LEFT, |
| wm::SHELF_ALIGNMENT_RIGHT, wm::SHELF_ALIGNMENT_BOTTOM_LOCKED, |
| @@ -1006,6 +1007,10 @@ TEST_F(ShelfViewTest, OverflowArrowForShelfPosition) { |
| test_api_->overflow_bubble()->IsShowing()); |
| EXPECT_EQ(test_api_->overflow_bubble()->bubble_view()->arrow(), kArrows[i]); |
| + OverflowBubbleViewTestAPI bubble_view_api( |
| + test_api_->overflow_bubble()->bubble_view()); |
| + EXPECT_EQ(bubble_view_api.GetBubbleFrameView()->bubble_border()->arrow(), |
|
sky
2016/04/29 17:17:27
nit: order for assertions is expected, actual. Isn
Greg Levin
2016/05/02 00:49:19
Done.
|
| + kArrows[i]); |
| } |
| } |