Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: ui/views/bubble/bubble_frame_view.h

Issue 1866403005: Fix rtl shelf overflow bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_dialog_delegate.cc ('k') | ui/views/bubble/bubble_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_frame_view.h
diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h
index 6f92883c13b51247507b4d984196bac827e19c86..910bad7739920e82b49feabea75d580076409490 100644
--- a/ui/views/bubble/bubble_frame_view.h
+++ b/ui/views/bubble/bubble_frame_view.h
@@ -72,6 +72,8 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
BubbleBorder* bubble_border() const { return bubble_border_; }
void SetBubbleBorder(std::unique_ptr<BubbleBorder> border);
+ void set_mirror_arrow_in_rtl(bool mirror) { mirror_arrow_in_rtl_ = mirror; }
+
gfx::Insets content_margins() const { return content_margins_; }
void SetFootnoteView(View* view);
@@ -114,6 +116,9 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
// The bubble border.
BubbleBorder* bubble_border_;
+ // Adjust insets to account for the mirrored arrow in RTL layout.
msw 2016/04/28 20:16:34 nit: // Used to adjust insets when the arrow is
Greg Levin 2016/04/29 14:32:04 Moved into non_client_view.h, and comment changed
+ bool mirror_arrow_in_rtl_;
+
// Margins around the title label.
gfx::Insets title_margins_;
« no previous file with comments | « ui/views/bubble/bubble_dialog_delegate.cc ('k') | ui/views/bubble/bubble_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698