Fix rtl shelf overflow bubble

ui/views/window/non_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/non_client_view.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/hit_test.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/views/rect_based_targeting_utils.h"
@@ skipping 25 matching lines @@
 bool NonClientFrameView::GetClientMask(const gfx::Size& size,
                                        gfx::Path* mask) const {
   return false;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NonClientView, public:
 
 NonClientView::NonClientView()
     : client_view_(nullptr),
+      mirror_client_in_rtl_(true),
       overlay_view_(nullptr) {
   SetEventTargeter(
       std::unique_ptr<views::ViewTargeter>(new views::ViewTargeter(this)));
 }
 
 NonClientView::~NonClientView() {
   // This value may have been reset before the window hierarchy shuts down,
   // so we need to manually remove it.
   RemoveChildView(frame_view_.get());
 }
@@ skipping 102 matching lines @@
 }
 
 gfx::Size NonClientView::GetMaximumSize() const {
   return frame_view_->GetMaximumSize();
 }
 
 void NonClientView::Layout() {
   LayoutFrameView();
 
   // Then layout the ClientView, using those bounds.
-  client_view_->SetBoundsRect(frame_view_->GetBoundsForClientView());
+  gfx::Rect client_bounds = frame_view_->GetBoundsForClientView();
+
+  // RTL code will mirror the ClientView in the frame by default.  If this isn't
+  // desired, pre-mirror it here so the subsequent mirror results in a no-op.

[sky, 2016/04/29 17:17:27]

nit: you're not doing pre-mirror here, rather another mirror to get the original
value.

[Greg Levin, 2016/05/02 00:49:19]

Done.

+  if (base::i18n::IsRTL() && !mirror_client_in_rtl_)
+    client_bounds.set_x(GetMirroredXForRect(client_bounds));
+
+  client_view_->SetBoundsRect(client_bounds);
 
   gfx::Path client_clip;
   if (frame_view_->GetClientMask(client_view_->size(), &client_clip))
     client_view_->set_clip_path(client_clip);
 
   // We need to manually call Layout on the ClientView as well for the same
   // reason as above.
   client_view_->Layout();
 
   if (overlay_view_ && overlay_view_->visible())
@@ skipping 157 matching lines @@
   // the client view.
   return !GetWidget()->client_view()->bounds().Intersects(rect);
 }
 
 void NonClientFrameView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   // Overridden to do nothing. The NonClientView manually calls Layout on the
   // FrameView when it is itself laid out, see comment in NonClientView::Layout.
 }
 
 }  // namespace views