Fix rtl shelf overflow bubble

ui/views/bubble/bubble_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_frame_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "build/build_config.h"
@@ skipping 54 matching lines @@
 }
 
 }  // namespace
 
 // static
 const char BubbleFrameView::kViewClassName[] = "BubbleFrameView";
 
 BubbleFrameView::BubbleFrameView(const gfx::Insets& title_margins,
                                  const gfx::Insets& content_margins)
     : bubble_border_(nullptr),
+      mirror_arrow_in_rtl_(true),
       title_margins_(title_margins),
       content_margins_(content_margins),
       title_icon_(new views::ImageView()),
       title_(nullptr),
       close_(nullptr),
       footnote_container_(nullptr),
       close_button_clicked_(false) {
   AddChildView(title_icon_);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
@@ skipping 28 matching lines @@
   // Windows will automatically create a tooltip for the close button based on
   // the HTCLOSE result from NonClientHitTest().
   close->SetTooltipText(l10n_util::GetStringUTF16(IDS_APP_CLOSE));
 #endif
   return close;
 }
 
 gfx::Rect BubbleFrameView::GetBoundsForClientView() const {
   gfx::Rect client_bounds = GetContentsBounds();
   client_bounds.Inset(GetInsets());
+
+  // After GetBoundsForClientView() returns, RTL code will mirror the ClientView
+  // in the bubble.  If we're not mirroring the arrow, we don't want this, so we
+  // pre-mirror here so the subsequent swap results in a no-op.
+  if (base::i18n::IsRTL() && !mirror_arrow_in_rtl_)
+    client_bounds.set_x(GetMirroredXForRect(client_bounds));
+
   if (footnote_container_) {
     client_bounds.set_height(client_bounds.height() -
                              footnote_container_->height());
   }
   return client_bounds;
 }
 
 gfx::Rect BubbleFrameView::GetWindowBoundsForClientBounds(
     const gfx::Rect& client_bounds) const {
   gfx::Size size(GetSizeForClientSize(client_bounds.size()));
@@ skipping 377 matching lines @@
   size.Enlarge(client_insets.width(), client_insets.height());
   size.SetToMax(gfx::Size(title_bar_width, 0));
 
   if (footnote_container_)
     size.Enlarge(0, footnote_container_->GetHeightForWidth(size.width()));
 
   return size;
 }
 
 }  // namespace views