Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1866403003: Auto-reboot the chromium.gpu and chromium.gpu.fyi bots. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, agable
CC:
ajuma, chromium-reviews, dnj, infra-reviews+build_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Auto-reboot the chromium.gpu and chromium.gpu.fyi bots. Auto-reboots were disabled some time ago in the spirit of efficiency, but this caused problems like lingering processes on Windows which were severely detrimental. The only four slaves that do not auto-reboot are Linux slaves which use the "subdir" property to run multiple slaves on the same physical host and can not be auto-rebooted. BUG=601640 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299786

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment based on dpranke's feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -127 lines) Patch
M masters/master.chromium.gpu.fyi/slaves.cfg View 1 36 chunks +72 lines, -84 lines 0 comments Download
M masters/master.chromium.gpu/slaves.cfg View 1 17 chunks +34 lines, -43 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ken Russell (switch to Gerrit)
PTAL. Thanks.
4 years, 8 months ago (2016-04-08 00:36:42 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1866403003/diff/1/masters/master.chromium.gpu.fyi/slaves.cfg File masters/master.chromium.gpu.fyi/slaves.cfg (right): https://codereview.chromium.org/1866403003/diff/1/masters/master.chromium.gpu.fyi/slaves.cfg#newcode15 masters/master.chromium.gpu.fyi/slaves.cfg:15: # All bots on these waterfalls are auto-rebooted between ...
4 years, 8 months ago (2016-04-08 00:39:52 UTC) #3
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1866403003/diff/1/masters/master.chromium.gpu.fyi/slaves.cfg File masters/master.chromium.gpu.fyi/slaves.cfg (right): https://codereview.chromium.org/1866403003/diff/1/masters/master.chromium.gpu.fyi/slaves.cfg#newcode15 masters/master.chromium.gpu.fyi/slaves.cfg:15: # All bots on these waterfalls are auto-rebooted between ...
4 years, 8 months ago (2016-04-08 00:48:38 UTC) #4
agable
lgtm
4 years, 8 months ago (2016-04-08 00:52:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866403003/20001
4 years, 8 months ago (2016-04-08 01:01:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3713)
4 years, 8 months ago (2016-04-08 01:08:09 UTC) #9
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-08 01:08:37 UTC) #10
Ken Russell (switch to Gerrit)
On 2016/04/08 01:08:09, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-08 01:09:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866403003/20001
4 years, 8 months ago (2016-04-08 01:09:28 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 01:17:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299786

Powered by Google App Engine
This is Rietveld 408576698