Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1866373002: Update V8 to version 5.1.294. (Closed)

Created:
4 years, 8 months ago by v8-autoroll
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.1.294. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23da806c..64896eeb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/a57dfe07b9adf34a3d952b28b2b15f9ac122ca29 Cr-Commit-Position: refs/heads/master@{#386020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
v8-autoroll
4 years, 8 months ago (2016-04-07 15:02:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866373002/1
4 years, 8 months ago (2016-04-07 15:02:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/201297)
4 years, 8 months ago (2016-04-07 16:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866373002/1
4 years, 8 months ago (2016-04-07 16:30:40 UTC) #7
Michael Achenbach
V8 again :/ https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/207336/steps/webgl_conformance_tests%20on%20Intel%20GPU%20on%20Mac%20%28with%20patch%29%20on%20Mac-10.10/logs/stdio
4 years, 8 months ago (2016-04-07 16:56:34 UTC) #8
Michael Hablich
On 2016/04/07 16:56:34, Michael Achenbach wrote: > V8 again :/ > https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/207336/steps/webgl_conformance_tests%20on%20Intel%20GPU%20on%20Mac%20%28with%20patch%29%20on%20Mac-10.10/logs/stdio Linux also crashing ...
4 years, 8 months ago (2016-04-07 17:12:22 UTC) #9
Michael Achenbach
According to https://codereview.chromium.org/1873703002 it doesn't repro anymore.
4 years, 8 months ago (2016-04-08 08:05:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866373002/1
4 years, 8 months ago (2016-04-08 08:05:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 08:46:31 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a57dfe07b9adf34a3d952b28b2b15f9ac122ca29 Cr-Commit-Position: refs/heads/master@{#386020}
4 years, 8 months ago (2016-04-08 08:48:10 UTC) #16
Michael Hablich
4 years, 8 months ago (2016-04-08 09:59:21 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1871843002/ by hablich@chromium.org.

The reason for reverting is: Makes GPU tests flaky.

Powered by Google App Engine
This is Rietveld 408576698