Measure usage of image/media/plugin/text documents

Measure usage of generated documents (image/media/plugin/etc)

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrEAgAJ

This *InFrame counters are intended as an estimate of cases where a
script in the containing document could look at the generated DOM.

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org

Committed: https://crrev.com/6a361fd629fd216c5cb0a1108228a1d10585a136
Cr-Commit-Position: refs/heads/master@{#388723}

[philipj_slow, 2016-04-07 11:56:18]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 11:56:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866343002/1

[philipj_slow, 2016-04-07 11:57:07]

PTAL. I tested it manually by playing around with data:video/webm, and similar
at the top-level and iframes, and see them being hit in chrome://histograms

[commit-bot: I haz the power, 2016-04-07 13:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 13:29:02]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2016-04-07 14:41:34]

Description was changed from

==========
Measure usage of image/media/plugin/text documents

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org
==========

to

==========
Measure usage of image/media/plugin/text documents

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org
==========

[philipj_slow, 2016-04-07 14:42:38]

I just found issue 597380. I didn't do SinkDocument or HTMLViewSourceDocument,
are either of those web observable?

[Ilya Sherman, 2016-04-07 18:42:05]

histograms.xml lgtm

[pdr., 2016-04-07 21:56:42]

On 2016/04/07 at 18:42:05, isherman wrote:
> histograms.xml lgtm

LGTM

[esprehn, 2016-04-07 22:07:55]

On 2016/04/07 at 14:42:38, philipj wrote:
> I just found issue 597380. I didn't do SinkDocument or HTMLViewSourceDocument,
are either of those web observable?

I don't know what SinkDocument does, ViewSourceDocument is users viewing
view-source:// urls, that would certainly be nice to measure.

[philipj_slow, 2016-04-08 08:58:28]

Description was changed from

==========
Measure usage of image/media/plugin/text documents

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org
==========

to

==========
Measure usage of generated documents (image/media/plugin/etc)

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

This *InFrame counters are intended as an estimate of cases where a
script in the containing document could look at the generated DOM.

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org
==========

[philipj_slow, 2016-04-08 09:00:31]

On 2016/04/07 22:07:55, esprehn wrote:
> On 2016/04/07 at 14:42:38, philipj wrote:
> > I just found issue 597380. I didn't do SinkDocument or
HTMLViewSourceDocument,
> are either of those web observable?
> 
> I don't know what SinkDocument does, ViewSourceDocument is users viewing
> view-source:// urls, that would certainly be nice to measure.

I've added SinkDocument and ViewSourceDocument now too. SinkDocument replaces a
PluginDocument for sandboxed plugins.

pdr@, do you remember why you measured in the parser bits and not in the
*Document constructors? I've just followed your lead.

[pdr., 2016-04-08 20:08:34]

On 2016/04/08 at 09:00:31, philipj wrote:
> On 2016/04/07 22:07:55, esprehn wrote:
> > On 2016/04/07 at 14:42:38, philipj wrote:
> > > I just found issue 597380. I didn't do SinkDocument or
HTMLViewSourceDocument,
> > are either of those web observable?
> > 
> > I don't know what SinkDocument does, ViewSourceDocument is users viewing
> > view-source:// urls, that would certainly be nice to measure.
> 
> I've added SinkDocument and ViewSourceDocument now too. SinkDocument replaces
a PluginDocument for sandboxed plugins.
> 
> pdr@, do you remember why you measured in the parser bits and not in the
*Document constructors? I've just followed your lead.

I think this was originally done to measure XML parsing and has just been copied
since then.

[philipj_slow, 2016-04-20 12:22:06]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 12:22:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866343002/40001

[commit-bot: I haz the power, 2016-04-20 12:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 12:24:29]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[philipj_slow, 2016-04-20 12:26:14]

On 2016/04/08 20:08:34, pdr wrote:
> On 2016/04/08 at 09:00:31, philipj wrote:
> > On 2016/04/07 22:07:55, esprehn wrote:
> > > On 2016/04/07 at 14:42:38, philipj wrote:
> > > > I just found issue 597380. I didn't do SinkDocument or
> HTMLViewSourceDocument,
> > > are either of those web observable?
> > > 
> > > I don't know what SinkDocument does, ViewSourceDocument is users viewing
> > > view-source:// urls, that would certainly be nice to measure.
> > 
> > I've added SinkDocument and ViewSourceDocument now too. SinkDocument
replaces
> a PluginDocument for sandboxed plugins.
> > 
> > pdr@, do you remember why you measured in the parser bits and not in the
> *Document constructors? I've just followed your lead.
> 
> I think this was originally done to measure XML parsing and has just been
copied
> since then.

In the XMLDocument case, it looks like it's done in the parser because of those
extra conditions ("This is XML being used as a document resource.") that aren't
known in the XMLDocument constructor.

For these, it looks like it could all be in the cosntructors, so I moved it in
PS3. Also added a test to convince myself that this didn't break everything, and
manually tested that in the top-level case, ImageDocument but not
ImageDocumentInFrame is counted.

PTAL?

[philipj_slow, 2016-04-20 12:35:45]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 12:35:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866343002/60001

[commit-bot: I haz the power, 2016-04-20 14:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:08:22]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-04-20 20:22:20]

On 2016/04/20 at 14:08:22, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

Super nice, LGTM

[philipj_slow, 2016-04-21 08:34:23]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2016-04-21 08:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1866343002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-21 08:34:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866343002/60001

[commit-bot: I haz the power, 2016-04-21 08:39:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:32:42]

Description was changed from

==========
Measure usage of generated documents (image/media/plugin/etc)

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

This *InFrame counters are intended as an estimate of cases where a
script in the containing document could look at the generated DOM.

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org
==========

to

==========
Measure usage of generated documents (image/media/plugin/etc)

As discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/u79ubJvsTbI/c_kSGKrE...

This *InFrame counters are intended as an estimate of cases where a
script in the containing document could look at the generated DOM.

BUG=597380
R=esprehn@chromium.org,pdr@chromium.org
TBR=isherman@chromium.org

Committed: https://crrev.com/6a361fd629fd216c5cb0a1108228a1d10585a136
Cr-Commit-Position: refs/heads/master@{#388723}
==========

[commit-bot: I haz the power, 2016-04-22 19:32:44]

Patchset 4 (id:??) landed as
https://crrev.com/6a361fd629fd216c5cb0a1108228a1d10585a136
Cr-Commit-Position: refs/heads/master@{#388723}