Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248
Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
Cr-Commit-Position: refs/heads/master@{#386923}

Committed: https://crrev.com/7791bb415868eac7b981f1fb1366947ad984cdef
Cr-Commit-Position: refs/heads/master@{#387198}

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:48:08]

suzyh@chromium.org changed reviewers:
+ jsbell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:49:14]

Description was changed from

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

BUG=600248
==========

to

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248
==========

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:50:41]

After https://codereview.chromium.org/1854003004 updating the rest of
web-platform-tests, this patch adds in the web-animations tests. Let me know if
I should add anyone else as a reviewer as well. Thanks!

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:50:52]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 03:51:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/1

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:51:05]

The CQ bit was unchecked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:51:32]

On 2016/04/08 at 03:50:41, suzyh wrote:
> After https://codereview.chromium.org/1854003004 updating the rest of
web-platform-tests, this patch adds in the web-animations tests. Let me know if
I should add anyone else as a reviewer as well. Thanks!

Whoops, missed a step. This isn't ready for review yet :-/

[suzyh_UTC10 (ex-contributor), 2016-04-08 04:29:03]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 04:29:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/40001

[commit-bot: I haz the power, 2016-04-08 04:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 04:33:28]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[suzyh_UTC10 (ex-contributor), 2016-04-08 04:35:20]

suzyh@chromium.org changed reviewers:
+ shans@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 04:35:54]

OK, this is ready for review now. I think the CQ dry run failure is because the
patch it depends on hasn't landed yet. I'll retry the dry run when that's in.

[suzyh_UTC10 (ex-contributor), 2016-04-08 06:36:06]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 06:36:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/60001

[commit-bot: I haz the power, 2016-04-08 07:53:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 07:53:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-04-08 08:17:18]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 08:17:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/80001

[commit-bot: I haz the power, 2016-04-08 09:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 09:13:23]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-04-08 17:01:27]

generally lgtm, but some comments/questions about the imports.

Please fix the W3CImportExpectations entry, otherwise I'm find with landing
as-is.

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1585: crbug.com/600248
imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress.html
[ Crash ]
The intent for importing these w/ crashes rather than not importing is that we
intend to fix these ASAP, correct?

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1587: crbug.com/600248
imported/web-platform-tests/web-animations/animation-effect-timing/endDelay.html
[ Failure ]
Why [Failure] rather than an expected.txt entry?

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1588: crbug.com/600248
imported/web-platform-tests/web-animations/animation/constructor.html [ Failure
Timeout ]
Flaky is sad :( but I agree this is the right way to handle these.

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/W3CImportExpectations (left):

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/W3CImportExpectations:292:
imported/web-platform-tests/web-animations [ Skip ]
Please follow the pattern documented above, rather than just removing the [Skip]
entry:

## Owners: EMAIL_ADDRESS_HERE
# DIRECTORY [ Pass ]

[suzyh_UTC10 (ex-contributor), 2016-04-11 23:21:05]

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1585: crbug.com/600248
imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress.html
[ Crash ]
On 2016/04/08 at 17:01:27, jsbell (OOO 4.11-4.12) wrote:
> The intent for importing these w/ crashes rather than not importing is that we
intend to fix these ASAP, correct?

Correct. Crashing is bad and I want to fix it!

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1587: crbug.com/600248
imported/web-platform-tests/web-animations/animation-effect-timing/endDelay.html
[ Failure ]
On 2016/04/08 at 17:01:27, jsbell (OOO 4.11-4.12) wrote:
> Why [Failure] rather than an expected.txt entry?

Unfortunately for this test, the current expected output has a non-deterministic
element. The "onfinish event is fired currentTime is after endTime" test is
failing an assertion that tests the currentTime value of a timeline. The test
output is printing the time value that it got, which is different every time the
test runs.

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/W3CImportExpectations (left):

https://codereview.chromium.org/1866333004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/W3CImportExpectations:292:
imported/web-platform-tests/web-animations [ Skip ]
On 2016/04/08 at 17:01:27, jsbell (OOO 4.11-4.12) wrote:
> Please follow the pattern documented above, rather than just removing the
[Skip] entry:
> 
> ## Owners: EMAIL_ADDRESS_HERE
> # DIRECTORY [ Pass ]

Oh, whoops, I missed this. If all else fails, read the instructions, right? haha

Done.

[suzyh_UTC10 (ex-contributor), 2016-04-12 02:54:41]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org
- shans@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-12 02:55:04]

-shans +alancutter since Shane is OOO

[suzyh_UTC10 (ex-contributor), 2016-04-13 00:43:01]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 00:43:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/120001

[commit-bot: I haz the power, 2016-04-13 00:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:46:28]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-04-13 00:54:20]

lgtm with nit.

https://codereview.chromium.org/1866333004/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/README.md
(right):

https://codereview.chromium.org/1866333004/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/README.md:4:
Specification: http://w3c.github.io/web-animations/
These tests also cover level 2: https://w3c.github.io/web-animations/level-2/

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:40:59]

On 2016/04/13 at 00:54:20, alancutter wrote:
> lgtm with nit.
> 
>
https://codereview.chromium.org/1866333004/diff/120001/third_party/WebKit/Lay...
> File
third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/README.md
(right):
> 
>
https://codereview.chromium.org/1866333004/diff/120001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/README.md:4:
Specification: http://w3c.github.io/web-animations/
> These tests also cover level 2: https://w3c.github.io/web-animations/level-2/

This file comes from upstream. This should probably be filed as a bug against
upstream rather than modified here.

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:48:33]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:48:45]

The CQ bit was unchecked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-13 01:52:33]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 01:52:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/140001

[commit-bot: I haz the power, 2016-04-13 03:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 03:00:50]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-04-13 06:21:00]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-13 06:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1866333004/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-13 06:21:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/140001

[commit-bot: I haz the power, 2016-04-13 06:27:38]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-13 06:28:47]

Description was changed from

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248
==========

to

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248

Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
Cr-Commit-Position: refs/heads/master@{#386923}
==========

[commit-bot: I haz the power, 2016-04-13 06:28:49]

Patchset 8 (id:??) landed as
https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
Cr-Commit-Position: refs/heads/master@{#386923}

[vabr (Chromium), 2016-04-13 12:25:46]

On 2016/04/13 06:28:49, commit-bot: I haz the power wrote:
> Patchset 8 (id:??) landed as
> https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

This seems to have caused failures in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8806,
will speculatively revert soon.

[vabr (Chromium), 2016-04-13 12:28:28]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1883663003/ by vabr@chromium.org.

The reason for reverting is: Suspected culprit of bot breakage, see
http://crbug.com/600248#c5..

[jsbell, 2016-04-13 16:31:00]

On 2016/04/13 12:25:46, vabr (Chromium) wrote:
> On 2016/04/13 06:28:49, commit-bot: I haz the power wrote:
> > Patchset 8 (id:??) landed as
> > https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> > Cr-Commit-Position: refs/heads/master@{#386923}
> 
> This seems to have caused failures in
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8806,
> will speculatively revert soon.

Heh, looks like it simply didn't crash on some platforms.

We can probably reland with [ Crash Pass ] in TestExpectations

[suzyh_UTC10 (ex-contributor), 2016-04-13 23:01:52]

On 2016/04/13 at 16:31:00, jsbell wrote:
> On 2016/04/13 12:25:46, vabr (Chromium) wrote:
> > On 2016/04/13 06:28:49, commit-bot: I haz the power wrote:
> > > Patchset 8 (id:??) landed as
> > > https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> > > Cr-Commit-Position: refs/heads/master@{#386923}
> > 
> > This seems to have caused failures in
> >
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8806,
> > will speculatively revert soon.
> 
> Heh, looks like it simply didn't crash on some platforms.
> 
> We can probably reland with [ Crash Pass ] in TestExpectations

Well, [ Crash Failure ], but yes, that's what I'll do.

[jsbell, 2016-04-13 23:33:50]

On 2016/04/13 23:01:52, suzyh wrote:
> Well, [ Crash Failure ], but yes, that's what I'll do.

Oooops, right - I thought I saw expected files for these. :P Don't mind me,
carry on...

[suzyh_UTC10 (ex-contributor), 2016-04-14 00:06:43]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 00:07:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/160001

[suzyh_UTC10 (ex-contributor), 2016-04-14 00:07:46]

On 2016/04/13 at 23:33:50, jsbell wrote:
> On 2016/04/13 23:01:52, suzyh wrote:
> > Well, [ Crash Failure ], but yes, that's what I'll do.
> 
> Oooops, right - I thought I saw expected files for these. :P Don't mind me,
carry on...

I've updated TestExpectations, reopened this patch and triggered a new dry run.
I'm not sure if I need a re-review in order to reland?

[jsbell, 2016-04-14 00:28:17]

On 2016/04/14 00:07:46, suzyh wrote:
> On 2016/04/13 at 23:33:50, jsbell wrote:
> > On 2016/04/13 23:01:52, suzyh wrote:
> > > Well, [ Crash Failure ], but yes, that's what I'll do.
> > 
> > Oooops, right - I thought I saw expected files for these. :P Don't mind me,
> carry on...
> 
> I've updated TestExpectations, reopened this patch and triggered a new dry
run.
> I'm not sure if I need a re-review in order to reland?

No, but lgtm anyway

[commit-bot: I haz the power, 2016-04-14 01:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 01:20:52]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:27:23]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-14 01:27:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1866333004/#ps160001
(title: "Add Failure option for two TestExpectations entries")

[commit-bot: I haz the power, 2016-04-14 01:27:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333004/160001

[commit-bot: I haz the power, 2016-04-14 01:34:50]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-14 01:37:03]

Description was changed from

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248

Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
Cr-Commit-Position: refs/heads/master@{#386923}
==========

to

==========
Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.

This patch adds web-animations to the list of directories imported
from web-platform-tests.

BUG=600248

Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
Cr-Commit-Position: refs/heads/master@{#386923}

Committed: https://crrev.com/7791bb415868eac7b981f1fb1366947ad984cdef
Cr-Commit-Position: refs/heads/master@{#387198}
==========

[commit-bot: I haz the power, 2016-04-14 01:37:05]

Patchset 9 (id:??) landed as
https://crrev.com/7791bb415868eac7b981f1fb1366947ad984cdef
Cr-Commit-Position: refs/heads/master@{#387198}