Remove IFDE_Image, IFDE_PathSet, IFDE_ImageSet, and IFDE_WidgetSet.

Remove IFDE_Image, IFDE_PathSet, IFDE_ImageSet, and IFDE_WidgetSet.

These interfaces were not implemented, removed.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/08153b16fb1c7e9849cc33f1b9d4f1521240d18e

[dsinclair, 2016-04-07 14:35:27]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-04-07 14:35:28]

PTAL.

This one was a bit tricker untangling some of the code.

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h
File xfa/fde/fde_brush.h (left):

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h#oldcode123
xfa/fde/fde_brush.h:123: virtual void SetImage(IFDE_Image* pImage, FX_BOOL
bAutoRelease) = 0;
SetImage was never called, so I also removed GetImage as it would always be
nullptr.

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp
File xfa/fde/fde_gedevice.cpp (left):

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp#ol...
xfa/fde/fde_gedevice.cpp:451: IFDE_Image* pImage = pTextureBrush->GetImage();
This would just early exist as GetImage would always return nullptr.

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp
File xfa/fde/fde_iterator.cpp (left):

https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp#ol...
xfa/fde/fde_iterator.cpp:76: (eType == FDE_VISUALOBJ_Widget)
eType was set from pVisualSet->GetType of which there is nothing returning
_Widget.

[dsinclair, 2016-04-07 14:56:20]

On 2016/04/07 14:35:28, dsinclair wrote:
> PTAL.
> 
> This one was a bit tricker untangling some of the code.
> 
> https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h
> File xfa/fde/fde_brush.h (left):
> 
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h#oldcode123
> xfa/fde/fde_brush.h:123: virtual void SetImage(IFDE_Image* pImage, FX_BOOL
> bAutoRelease) = 0;
> SetImage was never called, so I also removed GetImage as it would always be
> nullptr.
> 
> https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp
> File xfa/fde/fde_gedevice.cpp (left):
> 
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp#ol...
> xfa/fde/fde_gedevice.cpp:451: IFDE_Image* pImage = pTextureBrush->GetImage();
> This would just early exist as GetImage would always return nullptr.
> 
> https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp
> File xfa/fde/fde_iterator.cpp (left):
> 
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp#ol...
> xfa/fde/fde_iterator.cpp:76: (eType == FDE_VISUALOBJ_Widget)
> eType was set from pVisualSet->GetType of which there is nothing returning
> _Widget.


Hm, looks like I broke a corpus test with this. Please hold off reviewing for
now.

[dsinclair, 2016-04-07 19:05:09]

On 2016/04/07 14:56:20, dsinclair wrote:
> On 2016/04/07 14:35:28, dsinclair wrote:
> > PTAL.
> > 
> > This one was a bit tricker untangling some of the code.
> > 
> > https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h
> > File xfa/fde/fde_brush.h (left):
> > 
> >
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_brush.h#oldcode123
> > xfa/fde/fde_brush.h:123: virtual void SetImage(IFDE_Image* pImage, FX_BOOL
> > bAutoRelease) = 0;
> > SetImage was never called, so I also removed GetImage as it would always be
> > nullptr.
> > 
> > https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp
> > File xfa/fde/fde_gedevice.cpp (left):
> > 
> >
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_gedevice.cpp#ol...
> > xfa/fde/fde_gedevice.cpp:451: IFDE_Image* pImage =
pTextureBrush->GetImage();
> > This would just early exist as GetImage would always return nullptr.
> > 
> > https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp
> > File xfa/fde/fde_iterator.cpp (left):
> > 
> >
>
https://codereview.chromium.org/1866333003/diff/1/xfa/fde/fde_iterator.cpp#ol...
> > xfa/fde/fde_iterator.cpp:76: (eType == FDE_VISUALOBJ_Widget)
> > eType was set from pVisualSet->GetType of which there is nothing returning
> > _Widget.
> 
> 
> Hm, looks like I broke a corpus test with this. Please hold off reviewing for
> now.


This is blocked on https://codereview.chromium.org/1874433002/ in order for me
to run the test to see why I broke the test.

[dsinclair, 2016-04-11 14:04:26]

PTAL.

I removed slightly too much in fde_iterator. Put back the m_dwFilter = dwObjects
and bug_434 passes successfully.

https://codereview.chromium.org/1866333003/diff/20001/xfa/fde/fde_iterator.cpp
File xfa/fde/fde_iterator.cpp (left):

https://codereview.chromium.org/1866333003/diff/20001/xfa/fde/fde_iterator.cp...
xfa/fde/fde_iterator.cpp:37: m_dwFilter = dwObjects &
~(uint32_t)FDE_VISUALOBJ_Widget;
Accidentally removed the instance variable m_dwFilter which broke bug_434.pdf

[dsinclair, 2016-04-12 13:02:18]

On 2016/04/11 14:04:26, dsinclair wrote:
> PTAL.
> 
> I removed slightly too much in fde_iterator. Put back the m_dwFilter =
dwObjects
> and bug_434 passes successfully.
> 
> https://codereview.chromium.org/1866333003/diff/20001/xfa/fde/fde_iterator.cpp
> File xfa/fde/fde_iterator.cpp (left):
> 
>
https://codereview.chromium.org/1866333003/diff/20001/xfa/fde/fde_iterator.cp...
> xfa/fde/fde_iterator.cpp:37: m_dwFilter = dwObjects &
> ~(uint32_t)FDE_VISUALOBJ_Widget;
> Accidentally removed the instance variable m_dwFilter which broke bug_434.pdf

Ping.

[Tom Sepez, 2016-04-12 16:50:42]

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_gedevice.cpp
File xfa/fde/fde_gedevice.cpp (right):

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_gedevice.cp...
xfa/fde/fde_gedevice.cpp:445: FX_BOOL
CFDE_FxgeDevice::FillTexturePath(IFDE_Brush* pBrush,
can this be removed entirely?

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_object.h
File xfa/fde/fde_object.h (right):

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_object.h#ne...
xfa/fde/fde_object.h:179: FX_BOOL m_bAutoRelease;
do we still need m_bAutoRelease?

[dsinclair, 2016-04-12 16:57:49]

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_gedevice.cpp
File xfa/fde/fde_gedevice.cpp (right):

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_gedevice.cp...
xfa/fde/fde_gedevice.cpp:445: FX_BOOL
CFDE_FxgeDevice::FillTexturePath(IFDE_Brush* pBrush,
On 2016/04/12 16:50:42, Tom Sepez wrote:
> can this be removed entirely?

Was removed by Brush cleanup CL.

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_object.h
File xfa/fde/fde_object.h (right):

https://codereview.chromium.org/1866333003/diff/40001/xfa/fde/fde_object.h#ne...
xfa/fde/fde_object.h:179: FX_BOOL m_bAutoRelease;
On 2016/04/12 16:50:42, Tom Sepez wrote:
> do we still need m_bAutoRelease?

Class removed.

[Tom Sepez, 2016-04-13 17:58:00]

lgtm

[dsinclair, 2016-04-13 17:58:30]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:58:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866333003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866333003/100001

[commit-bot: I haz the power, 2016-04-13 17:58:54]

Description was changed from

==========
Remove IFDE_Image, IFDE_PathSet, IFDE_ImageSet, and IFDE_WidgetSet.

These interfaces were not implemented, removed.

BUG=pdfium:468
==========

to

==========
Remove IFDE_Image, IFDE_PathSet, IFDE_ImageSet, and IFDE_WidgetSet.

These interfaces were not implemented, removed.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/08153b16fb1c7e9849cc33f1b9d4f1521240...
==========

[commit-bot: I haz the power, 2016-04-13 17:58:55]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/08153b16fb1c7e9849cc33f1b9d4f1521240...