Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1866333002: Support additive animations on CSS property transform (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)
Modified:
4 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support additive animations on CSS property transform This change adds support for additive animations on CSS property transform via element.animate(). BUG=437696 Committed: https://crrev.com/7445af7fe2c76b998303fdbe6969a6064b741534 Cr-Commit-Position: refs/heads/master@{#389694}

Patch Set 1 #

Patch Set 2 : WIP changes #

Patch Set 3 : Responsive tests #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Fix merge fail #

Patch Set 7 : Make test use explicit transform #

Total comments: 2

Patch Set 8 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/animations/composition/transform-composition.html View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js View 1 2 1 chunk +17 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/responsive/transform-responsive.html View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/zoom-responsive-transform-animation-expected.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/animation-overlap-with-children.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp View 1 2 3 4 5 6 7 1 chunk +214 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/LengthUnitsChecker.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/40001
4 years, 8 months ago (2016-04-13 04:30:18 UTC) #2
alancutter (OOO until 2018)
4 years, 8 months ago (2016-04-13 04:31:01 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/18228) ios_rel_device_ninja on ...
4 years, 8 months ago (2016-04-13 04:31:50 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/60001
4 years, 8 months ago (2016-04-13 05:29:10 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/211546)
4 years, 8 months ago (2016-04-13 06:39:02 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/80001
4 years, 8 months ago (2016-04-14 06:59:30 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/211063)
4 years, 8 months ago (2016-04-14 07:46:37 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/100001
4 years, 8 months ago (2016-04-14 07:59:35 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/204963)
4 years, 8 months ago (2016-04-14 09:15:09 UTC) #19
Eric Willigers
Looks good. compositing/layer-creation/animation-overlap-with-children.html is failing.
4 years, 8 months ago (2016-04-15 00:43:51 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/120001
4 years, 8 months ago (2016-04-15 03:46:14 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 04:50:29 UTC) #24
alancutter (OOO until 2018)
On 2016/04/15 at 00:43:51, ericwilligers wrote: > Looks good. > > compositing/layer-creation/animation-overlap-with-children.html is failing. Fixed.
4 years, 8 months ago (2016-04-18 04:18:03 UTC) #25
Eric Willigers
lgtm
4 years, 8 months ago (2016-04-18 04:51:27 UTC) #26
alancutter (OOO until 2018)
+timloh for changes to core outside of core/animation.
4 years, 8 months ago (2016-04-18 05:03:14 UTC) #28
alancutter (OOO until 2018)
timloh: Poke.
4 years, 8 months ago (2016-04-20 05:14:53 UTC) #29
Timothy Loh
lgtm for stuff outside core/animation https://codereview.chromium.org/1866333002/diff/120001/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp (right): https://codereview.chromium.org/1866333002/diff/120001/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp#newcode152 third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp:152: if (!argument->isPrimitiveValue()) when does ...
4 years, 8 months ago (2016-04-20 05:53:19 UTC) #30
alancutter (OOO until 2018)
https://codereview.chromium.org/1866333002/diff/120001/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp (right): https://codereview.chromium.org/1866333002/diff/120001/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp#newcode152 third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp:152: if (!argument->isPrimitiveValue()) On 2016/04/20 at 05:53:19, Timothy Loh wrote: ...
4 years, 8 months ago (2016-04-20 06:09:46 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/140001
4 years, 8 months ago (2016-04-21 08:28:06 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/191642)
4 years, 8 months ago (2016-04-21 08:53:37 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866333002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866333002/140001
4 years, 8 months ago (2016-04-26 00:51:57 UTC) #38
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 04:32:37 UTC) #40
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/7445af7fe2c76b998303fdbe6969a6064b741534
Cr-Commit-Position: refs/heads/master@{#389694}

Powered by Google App Engine
This is Rietveld 408576698