Source/bindings/v8/SerializedScriptValue.cpp - Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/SerializedScriptValue.cpp

diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp

index d735e2292b78c5b9f08ee9e4856358436b5f6ac3..c8437cfc56850104cb623a3a2f5ac27e5da9eed6 100644

--- a/Source/bindings/v8/SerializedScriptValue.cpp

+++ b/Source/bindings/v8/SerializedScriptValue.cpp

@@ -2326,7 +2326,7 @@ static void neuterArrayBufferInAllWorlds(ArrayBuffer* object)

{

v8::Isolate* isolate = v8::Isolate::GetCurrent();

if (isMainThread()) {

- Vector<RefPtr<DOMWrapperWorld> > worlds;

+ Vector<DOMWrapperWorld*> worlds;

DOMWrapperWorld::allWorldsInMainThread(worlds);

for (size_t i = 0; i < worlds.size(); i++) {

v8::Handle<v8::Object> wrapper = worlds[i]->domDataStore().get<V8ArrayBuffer>(object, isolate);