Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/bindings/v8/V8MutationCallback.cpp

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8MutationCallback.h ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 m_callback.setWeak(this, &setWeakCallback); 45 m_callback.setWeak(this, &setWeakCallback);
46 } 46 }
47 47
48 void V8MutationCallback::call(const Vector<RefPtr<MutationRecord> >& mutations, MutationObserver* observer) 48 void V8MutationCallback::call(const Vector<RefPtr<MutationRecord> >& mutations, MutationObserver* observer)
49 { 49 {
50 if (!canInvokeCallback()) 50 if (!canInvokeCallback())
51 return; 51 return;
52 52
53 v8::HandleScope handleScope(m_isolate); 53 v8::HandleScope handleScope(m_isolate);
54 54
55 v8::Handle<v8::Context> v8Context = toV8Context(executionContext(), m_world. get()); 55 v8::Handle<v8::Context> v8Context = toV8Context(executionContext(), m_world) ;
56 if (v8Context.IsEmpty()) 56 if (v8Context.IsEmpty())
57 return; 57 return;
58 58
59 v8::Context::Scope scope(v8Context); 59 v8::Context::Scope scope(v8Context);
60 60
61 v8::Handle<v8::Function> callback = m_callback.newLocal(m_isolate); 61 v8::Handle<v8::Function> callback = m_callback.newLocal(m_isolate);
62 if (callback.IsEmpty()) 62 if (callback.IsEmpty())
63 return; 63 return;
64 64
65 v8::Handle<v8::Value> observerHandle = toV8(observer, v8::Handle<v8::Object> (), m_isolate); 65 v8::Handle<v8::Value> observerHandle = toV8(observer, v8::Handle<v8::Object> (), m_isolate);
(...skipping 13 matching lines...) Expand all
79 exceptionCatcher.SetVerbose(true); 79 exceptionCatcher.SetVerbose(true);
80 ScriptController::callFunction(executionContext(), callback, thisObject, 2, argv, m_isolate); 80 ScriptController::callFunction(executionContext(), callback, thisObject, 2, argv, m_isolate);
81 } 81 }
82 82
83 void V8MutationCallback::setWeakCallback(const v8::WeakCallbackData<v8::Function , V8MutationCallback>& data) 83 void V8MutationCallback::setWeakCallback(const v8::WeakCallbackData<v8::Function , V8MutationCallback>& data)
84 { 84 {
85 data.GetParameter()->m_callback.clear(); 85 data.GetParameter()->m_callback.clear();
86 } 86 }
87 87
88 } // namespace WebCore 88 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8MutationCallback.h ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698