Source/bindings/templates/callback_interface.h - Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld*

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/templates/callback_interface.h

Issue 186633002: Change RefPtr<DOMWrapperWorld> that causes reference cycles to DOMWrapperWorld* Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {# http://www.chromium.org/blink/coding-style#TOC-License #}	1 {# http://www.chromium.org/blink/coding-style#TOC-License #}

2 /*	2 /*

3 * Copyright (C) 2013 Google Inc. All rights reserved.	3 * Copyright (C) 2013 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 virtual ~{{v8_class}}();	55 virtual ~{{v8_class}}();

56	56

57 {% for method in methods %}	57 {% for method in methods %}

58 virtual {{method.return_cpp_type}} {{method.name}}({{method.argument_declara tions \| join(', ')}}) OVERRIDE;	58 virtual {{method.return_cpp_type}} {{method.name}}({{method.argument_declara tions \| join(', ')}}) OVERRIDE;

59 {% endfor %}	59 {% endfor %}

60 private:	60 private:

61 {{v8_class}}(v8::Handle<v8::Function>, ExecutionContext*);	61 {{v8_class}}(v8::Handle<v8::Function>, ExecutionContext*);

62	62

63 v8::Isolate* m_isolate;	63 v8::Isolate* m_isolate;

64 ScopedPersistent<v8::Function> m_callback;	64 ScopedPersistent<v8::Function> m_callback;

65 RefPtr<DOMWrapperWorld> m_world;	65 DOMWrapperWorld* m_world;

66 };	66 };

67	67

68 }	68 }

69 {% endfilter %}	69 {% endfilter %}

70 #endif // {{v8_class}}_h	70 #endif // {{v8_class}}_h

OLD	NEW

« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.cpp » ('j') | no next file with comments »