Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1866323002: Add fieldtrial config for V8 serialize options. (Closed)

Created:
4 years, 8 months ago by vogelheim
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit), motek.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add fieldtrial config for V8 serialize options. V8 would like to gather real world performance data for two new serialization options. It was recommended to: 1. Pick one of two options for test, whichever you like better (more likely to advance). 2. Make sure to change test config (fieldtrial_testing_config_*.json) if your belief changes. I've picked "Serialize eager + pre-age code", since 1, this is the more aggressive proposal and 2, it increases the code coverage. (This option enables the code path for the other proposal + some additions.) This adds the field trial for all platforms except iOS, since iOS Chromium does not use V8. BUG=chromium:594551 Committed: https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022 Cr-Commit-Position: refs/heads/master@{#386033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vogelheim
Adding a fieldtrial for V8 serialize options. Additional context (design doc) in the referenced bug, ...
4 years, 8 months ago (2016-04-07 10:55:32 UTC) #2
Alexei Svitkine (slow)
lgtm Please edit your CL description to not mention Finch, since it's an internal codename.
4 years, 8 months ago (2016-04-07 15:16:14 UTC) #3
vogelheim
On 2016/04/07 15:16:14, Alexei Svitkine wrote: > Please edit your CL description to not mention ...
4 years, 8 months ago (2016-04-08 09:17:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866323002/1
4 years, 8 months ago (2016-04-08 09:18:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 10:05:44 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 10:07:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e10d2ca83e75f3381970df6f570001e6ce2d8022
Cr-Commit-Position: refs/heads/master@{#386033}

Powered by Google App Engine
This is Rietveld 408576698