Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1866303002: Rename Document::hasPendingStyleRecalc to hasPendingVisualUpdate. (Closed)

Created:
4 years, 8 months ago by Deokjin Kim
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Document::hasPendingStyleRecalc to hasPendingVisualUpdate. This CL is needed to better reflect the method's behavior. BUG=585653 Committed: https://crrev.com/ced8b162379d530d6644c248fe7802af90c0588e Cr-Commit-Position: refs/heads/master@{#385731}

Patch Set 1 #

Patch Set 2 : Revise description of commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Deokjin Kim
PTAL. Thank you in advance.
4 years, 8 months ago (2016-04-07 10:35:03 UTC) #3
rune
lgtm Nit: I think something like "... to better reflect the method's behavior." is more ...
4 years, 8 months ago (2016-04-07 11:15:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866303002/20001
4 years, 8 months ago (2016-04-07 11:31:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 12:52:04 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 12:54:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ced8b162379d530d6644c248fe7802af90c0588e
Cr-Commit-Position: refs/heads/master@{#385731}

Powered by Google App Engine
This is Rietveld 408576698