src/ports/SkFontHost_FreeType.cpp - Issue 1866293003: Decouple contrast boost from fake gamma.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_FreeType.cpp

Issue 1866293003: Decouple contrast boost from fake gamma. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Improve ignorePreBlend API, add storage type to enum Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_FreeType.cpp

diff --git a/src/ports/SkFontHost_FreeType.cpp b/src/ports/SkFontHost_FreeType.cpp

index 5c00d1b697194c33edb02cf9d2d6688ecc6bf9a2..44eb50ce406c8b7fdec44a1fef448ac1896aabd5 100644

--- a/src/ports/SkFontHost_FreeType.cpp

+++ b/src/ports/SkFontHost_FreeType.cpp

@@ -714,7 +714,8 @@ void SkTypeface_FreeType::onFilterRec(SkScalerContextRec* rec) const {

#ifndef SK_GAMMA_APPLY_TO_A8

if (!isLCD(*rec)) {

- rec->ignorePreBlend();

+ // SRGBTODO: Is this correct? Do we want contrast boost?

+ rec->ignorePreBlend();

}

#endif

}

« no previous file with comments | « src/gpu/text/GrTextUtils.cpp ('k') | src/ports/SkFontHost_mac.cpp » ('j') | no next file with comments »