sync/internal_api/attachments/attachment_downloader_impl_unittest.cc - Issue 1866243002: Convert //sync from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

Issue 1866243002: Convert //sync from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/engine/syncer_util_unittest.cc ('K') | « sync/internal_api/attachments/attachment_downloader_impl.cc ('k') | sync/internal_api/attachments/attachment_service_impl.cc » ('j') | sync/internal_api/public/attachments/attachment_service_proxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

diff --git a/sync/internal_api/attachments/attachment_downloader_impl_unittest.cc b/sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

index a2cb0b909ff300e94709e51b9ba7486f45a73116..74a0fab103d3a04c1ae00d332dc0700d1199fd5c 100644

--- a/sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

+++ b/sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

@@ -186,7 +186,7 @@ class AttachmentDownloaderImplTest : public testing::Test {

void DownloadDone(const AttachmentId& attachment_id,

const AttachmentDownloader::DownloadResult& result,

- scoped_ptr<Attachment> attachment);

+ std::unique_ptr<Attachment> attachment);

void VerifyDownloadResult(const AttachmentId& attachment_id,

const AttachmentDownloader::DownloadResult& result);

@@ -200,8 +200,8 @@ class AttachmentDownloaderImplTest : public testing::Test {

base::MessageLoopForIO message_loop_;

scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;

net::TestURLFetcherFactory url_fetcher_factory_;

- scoped_ptr<MockOAuth2TokenService> token_service_;

- scoped_ptr<AttachmentDownloader> attachment_downloader_;

+ std::unique_ptr<MockOAuth2TokenService> token_service_;

+ std::unique_ptr<AttachmentDownloader> attachment_downloader_;

ResultsMap download_results_;

int num_completed_downloads_;

const AttachmentId attachment_id_;

@@ -253,7 +253,7 @@ void AttachmentDownloaderImplTest::CompleteDownload(

void AttachmentDownloaderImplTest::DownloadDone(

const AttachmentId& attachment_id,

const AttachmentDownloader::DownloadResult& result,

- scoped_ptr<Attachment> attachment) {

+ std::unique_ptr<Attachment> attachment) {

download_results_.insert(std::make_pair(attachment_id, result));

if (result == AttachmentDownloader::DOWNLOAD_SUCCESS) {

// Successful download should be accompanied by valid attachment with