Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: sync/js/js_event_details_unittest.cc

Issue 1866243002: Convert //sync from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/js/js_event_details.h" 5 #include "sync/js/js_event_details.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include <memory>
8
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
10 namespace syncer { 11 namespace syncer {
11 namespace { 12 namespace {
12 13
13 class JsEventDetailsTest : public testing::Test {}; 14 class JsEventDetailsTest : public testing::Test {};
14 15
15 TEST_F(JsEventDetailsTest, EmptyList) { 16 TEST_F(JsEventDetailsTest, EmptyList) {
16 JsEventDetails details; 17 JsEventDetails details;
17 EXPECT_TRUE(details.Get().empty()); 18 EXPECT_TRUE(details.Get().empty());
18 EXPECT_EQ("{}", details.ToString()); 19 EXPECT_EQ("{}", details.ToString());
19 } 20 }
20 21
21 TEST_F(JsEventDetailsTest, FromDictionary) { 22 TEST_F(JsEventDetailsTest, FromDictionary) {
22 base::DictionaryValue dict; 23 base::DictionaryValue dict;
23 dict.SetString("foo", "bar"); 24 dict.SetString("foo", "bar");
24 dict.Set("baz", new base::ListValue()); 25 dict.Set("baz", new base::ListValue());
25 26
26 scoped_ptr<base::DictionaryValue> dict_copy(dict.DeepCopy()); 27 std::unique_ptr<base::DictionaryValue> dict_copy(dict.DeepCopy());
27 28
28 JsEventDetails details(&dict); 29 JsEventDetails details(&dict);
29 30
30 // |details| should take over |dict|'s data. 31 // |details| should take over |dict|'s data.
31 EXPECT_TRUE(dict.empty()); 32 EXPECT_TRUE(dict.empty());
32 EXPECT_TRUE(details.Get().Equals(dict_copy.get())); 33 EXPECT_TRUE(details.Get().Equals(dict_copy.get()));
33 } 34 }
34 35
35 } // namespace 36 } // namespace
36 } // namespace syncer 37 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698