Convert //sync from scoped_ptr to std::unique_ptr

Convert //sync from scoped_ptr to std::unique_ptr

BUG=554298
R=zea@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/c3e80570c413b058d8f855a695610b38072d6519
Cr-Commit-Position: refs/heads/master@{#385972}

[dcheng, 2016-04-07 01:44:42]

Largely an automated search-and-replace:
- Replace #include "base/memory/scoped_ptr.h" -> #include <memory>
- File uses make_scoped_ptr? Add include for "base/memory/ptr_util.h"
- Replace all instances of make_scoped_ptr with base::WrapUnique
- Replace all instances of scoped_ptr< with std::unique_ptr<.
- Attempt to build all targets and add #include "base/memory/scoped_ptr.h" to
files that don't build to fix IWYU failures.

[vabr (Chromium), 2016-04-07 02:04:10]

> - Attempt to build all targets and add #include "base/memory/scoped_ptr.h" to
> files that don't build to fix IWYU failures.

chrome/browser/ui/login/login_handler.h LGTM
Thanks!
Vaclav

[Nicolas Zea, 2016-04-07 21:48:58]

So I tried to point out places where IWYU was not being done. That said, that's
more of a cleanup that's maybe orthogonal to this change?

More generally though, would it make sense to just write a script that added
#include <memory> to any file that had unique_ptr (regardless of if it's a .cc
and the header already has it), and remove the <memory> include from any file
that doesn't have unique ptr?

https://codereview.chromium.org/1866243002/diff/1/sync/api/sync_data.cc
File sync/api/sync_data.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/api/sync_data.cc#newco...
sync/api/sync_data.cc:10: #include <memory>
can this be removed?

https://codereview.chromium.org/1866243002/diff/1/sync/api/sync_data_unittest.cc
File sync/api/sync_data_unittest.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/api/sync_data_unittest...
sync/api/sync_data_unittest.cc:9: #include <string>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/engine/get_updates_del...
File sync/engine/get_updates_delegate.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/engine/get_updates_del...
sync/engine/get_updates_delegate.h:8: #include "base/macros.h"
Include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/engine/sync_scheduler.h
File sync/engine/sync_scheduler.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/engine/sync_scheduler....
sync/engine/sync_scheduler.h:9: #include <string>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/engine/syncer.cc
File sync/engine/syncer.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/engine/syncer.cc#newcode7
sync/engine/syncer.cc:7: #include "base/auto_reset.h"
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/engine/syncer_util_uni...
File sync/engine/syncer_util_unittest.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/engine/syncer_util_uni...
sync/engine/syncer_util_unittest.cc:7: #include <stdint.h>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/at...
File sync/internal_api/public/attachments/attachment_service_proxy.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/at...
sync/internal_api/public/attachments/attachment_service_proxy.h:8: #include
<memory>
not needed?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/at...
File sync/internal_api/public/attachments/attachment_uploader.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/at...
sync/internal_api/public/attachments/attachment_uploader.h:8: #include <memory>
not needed?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/ht...
File sync/internal_api/public/http_bridge.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/ht...
sync/internal_api/public/http_bridge.h:10: #include <string>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/in...
File sync/internal_api/public/internal_components_factory.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/public/in...
sync/internal_api/public/internal_components_factory.h:13: #include <vector>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/sync_encr...
File sync/internal_api/sync_encryption_handler_impl.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/sync_encr...
sync/internal_api/sync_encryption_handler_impl.cc:11: #include <string>
include memory?

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/sync_encr...
File sync/internal_api/sync_encryption_handler_impl.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/internal_api/sync_encr...
sync/internal_api/sync_encryption_handler_impl.h:8: #include <memory>
remove?

https://codereview.chromium.org/1866243002/diff/1/sync/syncable/syncable_id_u...
File sync/syncable/syncable_id_unittest.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/syncable/syncable_id_u...
sync/syncable/syncable_id_unittest.cc:7: #include <memory>
remove?

https://codereview.chromium.org/1866243002/diff/1/sync/test/fake_server/fake_...
File sync/test/fake_server/fake_server_verifier.h (right):

https://codereview.chromium.org/1866243002/diff/1/sync/test/fake_server/fake_...
sync/test/fake_server/fake_server_verifier.h:10: #include <memory>
remove?

https://codereview.chromium.org/1866243002/diff/1/sync/util/cryptographer_uni...
File sync/util/cryptographer_unittest.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/util/cryptographer_uni...
sync/util/cryptographer_unittest.cc:7: #include <memory>
remove?

https://codereview.chromium.org/1866243002/diff/1/sync/util/nigori_unittest.cc
File sync/util/nigori_unittest.cc (right):

https://codereview.chromium.org/1866243002/diff/1/sync/util/nigori_unittest.c...
sync/util/nigori_unittest.cc:7: #include <memory>
remove

[dcheng, 2016-04-07 21:50:08]

dcheng@chromium.org changed reviewers:
+ vabr@chromium.org

[dcheng, 2016-04-07 21:50:09]

I've been adding the following boilerplate to emails:

"This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work."

That being said, I'll fix these particular instances since... why not.

[dcheng, 2016-04-07 22:36:55]

OK, comments should be addressed. Sorry I rebased too, I forgot to separate that
into a separate CL.

[Nicolas Zea, 2016-04-07 23:02:28]

LGTM (although looks like you need to rebase again)

[dcheng, 2016-04-07 23:34:48]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 23:34:50]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1866243002/#ps40001
(title: "Rebase and fix conflicts")

[commit-bot: I haz the power, 2016-04-07 23:35:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866243002/40001

[commit-bot: I haz the power, 2016-04-07 23:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 23:51:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-04-07 23:52:54]

dcheng@chromium.org changed reviewers:
+ thestig@chromium.org

[dcheng, 2016-04-07 23:52:55]

TBRing thestig for IWYU fixes in //chrome

[dcheng, 2016-04-07 23:53:02]

Description was changed from

==========
Convert //sync from scoped_ptr to std::unique_ptr

BUG=554298
R=zea@chromium.org
==========

to

==========
Convert //sync from scoped_ptr to std::unique_ptr

BUG=554298
R=zea@chromium.org
TBR=thestig@chromium.org
==========

[dcheng, 2016-04-07 23:53:04]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-07 23:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866243002/40001

[Lei Zhang, 2016-04-08 00:43:15]

lgtm

[commit-bot: I haz the power, 2016-04-08 03:19:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-08 03:20:52]

Description was changed from

==========
Convert //sync from scoped_ptr to std::unique_ptr

BUG=554298
R=zea@chromium.org
TBR=thestig@chromium.org
==========

to

==========
Convert //sync from scoped_ptr to std::unique_ptr

BUG=554298
R=zea@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/c3e80570c413b058d8f855a695610b38072d6519
Cr-Commit-Position: refs/heads/master@{#385972}
==========

[commit-bot: I haz the power, 2016-04-08 03:20:54]

Patchset 3 (id:??) landed as
https://crrev.com/c3e80570c413b058d8f855a695610b38072d6519
Cr-Commit-Position: refs/heads/master@{#385972}