Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 186623006: Refactor GCMNetworkChannelDelegateImpl (Closed)

Created:
6 years, 9 months ago by pavely
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, Mattias Nissler (ping if slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase #

Patch Set 3 : Fix build #

Patch Set 4 : Another rebase to resolve conflict with recent change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -366 lines) Patch
A chrome/browser/invalidation/gcm_invalidation_bridge.h View 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/invalidation/gcm_invalidation_bridge.cc View 1 2 3 1 chunk +253 lines, -0 lines 0 comments Download
A + chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc View 5 chunks +17 lines, -11 lines 0 comments Download
D chrome/browser/invalidation/gcm_network_channel_delegate_impl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/invalidation/gcm_network_channel_delegate_impl.cc View 1 2 3 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/browser/invalidation/gcm_network_channel_delegate_impl_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/browser/invalidation/invalidation_service_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/gcm_network_channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 50 (0 generated)
pavely
6 years, 9 months ago (2014-03-04 19:20:19 UTC) #1
rlarocque
https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc File chrome/browser/invalidation/gcm_invalidation_bridge.cc (right): https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc#newcode71 chrome/browser/invalidation/gcm_invalidation_bridge.cc:71: DetachFromThread(); Neat. I didn't know about this trick. I'll ...
6 years, 9 months ago (2014-03-04 19:43:06 UTC) #2
pavely
https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc File chrome/browser/invalidation/gcm_invalidation_bridge.cc (right): https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc#newcode80 chrome/browser/invalidation/gcm_invalidation_bridge.cc:80: ui_thread_task_runner_->PostTask( On 2014/03/04 19:43:06, rlarocque wrote: > Is this ...
6 years, 9 months ago (2014-03-04 20:14:42 UTC) #3
pavely
Adding Mattias
6 years, 9 months ago (2014-03-04 20:17:26 UTC) #4
rlarocque
https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc File chrome/browser/invalidation/gcm_invalidation_bridge.cc (right): https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/gcm_invalidation_bridge.cc#newcode80 chrome/browser/invalidation/gcm_invalidation_bridge.cc:80: ui_thread_task_runner_->PostTask( On 2014/03/04 20:14:42, pavely wrote: > On 2014/03/04 ...
6 years, 9 months ago (2014-03-04 21:30:18 UTC) #5
pavely
https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/ticl_invalidation_service.cc File chrome/browser/invalidation/ticl_invalidation_service.cc (right): https://codereview.chromium.org/186623006/diff/1/chrome/browser/invalidation/ticl_invalidation_service.cc#newcode403 chrome/browser/invalidation/ticl_invalidation_service.cc:403: gcm_invalidation_bridge_.reset(); On 2014/03/04 21:30:19, rlarocque wrote: > Should this ...
6 years, 9 months ago (2014-03-04 23:01:54 UTC) #6
rlarocque
LGTM
6 years, 9 months ago (2014-03-04 23:33:27 UTC) #7
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-04 23:40:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/1
6 years, 9 months ago (2014-03-04 23:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/1
6 years, 9 months ago (2014-03-05 01:19:43 UTC) #10
Mattias Nissler (ping if slow)
Happy to see this! I'll change my CL to handle the token minting for GCM ...
6 years, 9 months ago (2014-03-05 01:30:22 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 06:09:10 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=274975
6 years, 9 months ago (2014-03-05 06:09:11 UTC) #13
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 07:04:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/1
6 years, 9 months ago (2014-03-05 07:07:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 10:11:03 UTC) #16
commit-bot: I haz the power
Failed to apply patch for chrome/browser/invalidation/ticl_invalidation_service.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-05 10:11:05 UTC) #17
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 17:56:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/20001
6 years, 9 months ago (2014-03-05 17:56:51 UTC) #19
pavely
The CQ bit was unchecked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 17:58:29 UTC) #20
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 17:59:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/40001
6 years, 9 months ago (2014-03-05 18:01:59 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 18:30:11 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg, mac_chromium_compile_dbg, mac_chromium_rel Retried try job too often on ...
6 years, 9 months ago (2014-03-05 18:30:11 UTC) #24
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 18:53:40 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/100001
6 years, 9 months ago (2014-03-05 18:54:30 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:10:50 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275453
6 years, 9 months ago (2014-03-05 19:10:51 UTC) #28
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 19:39:20 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/100001
6 years, 9 months ago (2014-03-05 19:40:03 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 21:49:44 UTC) #31
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=207808
6 years, 9 months ago (2014-03-05 21:49:45 UTC) #32
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 22:08:53 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-05 22:10:35 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 23:12:31 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-05 23:12:31 UTC) #36
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-05 23:18:18 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-05 23:18:54 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-06 00:09:57 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:53:34 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 01:53:34 UTC) #41
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-06 02:09:38 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-06 02:14:08 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-06 03:00:18 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-06 03:21:47 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:20:05 UTC) #46
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276086
6 years, 9 months ago (2014-03-06 04:20:06 UTC) #47
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 9 months ago (2014-03-06 06:02:31 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/186623006/120001
6 years, 9 months ago (2014-03-06 06:03:06 UTC) #49
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:10:55 UTC) #50
Message was sent while issue was closed.
Change committed as 255337

Powered by Google App Engine
This is Rietveld 408576698