Issue 186623002: Merged r19594 into 3.24 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186623002: Merged r19594 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.24

Visibility:
Public.

Merged r19594 into 3.24 branch. Fix handling of constant global variable assignments. BUG=347904 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19653

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -21 lines)			Patch
M	src/hydrogen.cc	View	1 chunk	+19 lines, -10 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-347904.js	View	1 chunk	+4 lines, -11 lines	0 comments	Download
A +	test/test262ptestcfg.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM if you drop test/test262ptestcfg.py which seems out of place.

6 years, 9 months ago (2014-03-04 13:13:42 UTC) #2

Benedikt Meurer

6 years, 9 months ago (2014-03-04 13:14:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19653 (tree was closed).