third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 1866213002: [DevTools] Move inspect from Inspector to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 1866213002: [DevTools] Move inspect from Inspector to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inspector-connection

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/protocol.json ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index a1ec646a0e6bfb9f285b5ae69c1624533f5441a8..237e6d969ef871d7a2d458ceef7a9ac3fc04c7bf 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -37,6 +37,7 @@ public:

V8DebuggerImpl* debugger() const { return m_debugger; }

V8DebuggerAgentImpl* debuggerAgentImpl() { return m_debuggerAgent.get(); }

+ V8RuntimeAgentImpl* runtimeAgentImpl() { return m_runtimeAgent.get(); }

int contextGroupId() const { return m_contextGroupId; }

InjectedScript* findInjectedScript(ErrorString*, int contextId);

@@ -55,8 +56,6 @@ public:

void setClearConsoleCallback(PassOwnPtr<V8RuntimeAgent::ClearConsoleCallback> callback) { m_clearConsoleCallback = callback; }

V8RuntimeAgent::ClearConsoleCallback* clearConsoleCallback() { return m_clearConsoleCallback.get(); }

- void setInspectObjectCallback(PassOwnPtr<V8RuntimeAgent::InspectCallback> callback) { m_inspectCallback = callback; }

- V8RuntimeAgent::InspectCallback* inspectCallback() { return m_inspectCallback.get(); }

private:

friend class InspectedContext;

@@ -72,7 +71,6 @@ private:

OwnPtr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;

OwnPtr<V8ProfilerAgentImpl> m_profilerAgent;

- OwnPtr<V8RuntimeAgent::InspectCallback> m_inspectCallback;

OwnPtr<V8RuntimeAgent::ClearConsoleCallback> m_clearConsoleCallback;

};