Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: cc/test/layer_tree_test.cc

Issue 1866203004: Convert //cc from scoped_ptr to std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scopedptrcc: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_tree_test.h ('k') | cc/test/ordered_simple_task_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_tree_test.cc
diff --git a/cc/test/layer_tree_test.cc b/cc/test/layer_tree_test.cc
index 87a79debd6b8f21eeb25e8415e153d1057878ae3..82a9a04a9ac259a477db9f20bdbf538f5039be68 100644
--- a/cc/test/layer_tree_test.cc
+++ b/cc/test/layer_tree_test.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/location.h"
+#include "base/memory/ptr_util.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
#include "cc/animation/animation.h"
@@ -90,11 +91,12 @@ void CreateVirtualViewportLayers(Layer* root_layer,
// various actions.
class SingleThreadProxyForTest : public SingleThreadProxy {
public:
- static scoped_ptr<Proxy> Create(TestHooks* test_hooks,
- LayerTreeHost* host,
- LayerTreeHostSingleThreadClient* client,
- TaskRunnerProvider* task_runner_provider) {
- return make_scoped_ptr(new SingleThreadProxyForTest(
+ static std::unique_ptr<Proxy> Create(
+ TestHooks* test_hooks,
+ LayerTreeHost* host,
+ LayerTreeHostSingleThreadClient* client,
+ TaskRunnerProvider* task_runner_provider) {
+ return base::WrapUnique(new SingleThreadProxyForTest(
test_hooks, host, client, task_runner_provider));
}
@@ -152,7 +154,7 @@ class SingleThreadProxyForTest : public SingleThreadProxy {
// Adapts LayerTreeHostImpl for test. Runs real code, then invokes test hooks.
class LayerTreeHostImplForTesting : public LayerTreeHostImpl {
public:
- static scoped_ptr<LayerTreeHostImplForTesting> Create(
+ static std::unique_ptr<LayerTreeHostImplForTesting> Create(
TestHooks* test_hooks,
const LayerTreeSettings& settings,
LayerTreeHostImplClient* host_impl_client,
@@ -161,7 +163,7 @@ class LayerTreeHostImplForTesting : public LayerTreeHostImpl {
gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
TaskGraphRunner* task_graph_runner,
RenderingStatsInstrumentation* stats_instrumentation) {
- return make_scoped_ptr(new LayerTreeHostImplForTesting(
+ return base::WrapUnique(new LayerTreeHostImplForTesting(
test_hooks, settings, host_impl_client, task_runner_provider,
shared_bitmap_manager, gpu_memory_buffer_manager, task_graph_runner,
stats_instrumentation));
@@ -190,8 +192,8 @@ class LayerTreeHostImplForTesting : public LayerTreeHostImpl {
notify_ready_to_activate_was_blocked_(false) {}
void CreateResourceAndTileTaskWorkerPool(
- scoped_ptr<TileTaskWorkerPool>* tile_task_worker_pool,
- scoped_ptr<ResourcePool>* resource_pool) override {
+ std::unique_ptr<TileTaskWorkerPool>* tile_task_worker_pool,
+ std::unique_ptr<ResourcePool>* resource_pool) override {
test_hooks_->CreateResourceAndTileTaskWorkerPool(
this, tile_task_worker_pool, resource_pool);
}
@@ -335,9 +337,9 @@ class LayerTreeHostImplForTesting : public LayerTreeHostImpl {
class LayerTreeHostClientForTesting : public LayerTreeHostClient,
public LayerTreeHostSingleThreadClient {
public:
- static scoped_ptr<LayerTreeHostClientForTesting> Create(
+ static std::unique_ptr<LayerTreeHostClientForTesting> Create(
TestHooks* test_hooks) {
- return make_scoped_ptr(new LayerTreeHostClientForTesting(test_hooks));
+ return base::WrapUnique(new LayerTreeHostClientForTesting(test_hooks));
}
~LayerTreeHostClientForTesting() override {}
@@ -399,8 +401,8 @@ class LayerTreeHostClientForTesting : public LayerTreeHostClient,
void BeginMainFrameNotExpectedSoon() override {}
void RecordFrameTimingEvents(
- scoped_ptr<FrameTimingTracker::CompositeTimingSet> composite_events,
- scoped_ptr<FrameTimingTracker::MainFrameTimingSet> main_frame_events)
+ std::unique_ptr<FrameTimingTracker::CompositeTimingSet> composite_events,
+ std::unique_ptr<FrameTimingTracker::MainFrameTimingSet> main_frame_events)
override {}
private:
@@ -413,7 +415,7 @@ class LayerTreeHostClientForTesting : public LayerTreeHostClient,
// Adapts LayerTreeHost for test. Injects LayerTreeHostImplForTesting.
class LayerTreeHostForTesting : public LayerTreeHost {
public:
- static scoped_ptr<LayerTreeHostForTesting> Create(
+ static std::unique_ptr<LayerTreeHostForTesting> Create(
TestHooks* test_hooks,
CompositorMode mode,
LayerTreeHostClientForTesting* client,
@@ -424,18 +426,18 @@ class LayerTreeHostForTesting : public LayerTreeHost {
const LayerTreeSettings& settings,
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner,
- scoped_ptr<BeginFrameSource> external_begin_frame_source) {
+ std::unique_ptr<BeginFrameSource> external_begin_frame_source) {
LayerTreeHost::InitParams params;
params.client = client;
params.shared_bitmap_manager = shared_bitmap_manager;
params.gpu_memory_buffer_manager = gpu_memory_buffer_manager;
params.task_graph_runner = task_graph_runner;
params.settings = &settings;
- scoped_ptr<LayerTreeHostForTesting> layer_tree_host(
+ std::unique_ptr<LayerTreeHostForTesting> layer_tree_host(
new LayerTreeHostForTesting(test_hooks, &params, mode));
- scoped_ptr<TaskRunnerProvider> task_runner_provider =
+ std::unique_ptr<TaskRunnerProvider> task_runner_provider =
TaskRunnerProvider::Create(main_task_runner, impl_task_runner);
- scoped_ptr<Proxy> proxy;
+ std::unique_ptr<Proxy> proxy;
switch (mode) {
case CompositorMode::SINGLE_THREADED:
proxy = SingleThreadProxyForTest::Create(test_hooks,
@@ -471,7 +473,7 @@ class LayerTreeHostForTesting : public LayerTreeHost {
return layer_tree_host;
}
- scoped_ptr<LayerTreeHostImpl> CreateLayerTreeHostImpl(
+ std::unique_ptr<LayerTreeHostImpl> CreateLayerTreeHostImpl(
LayerTreeHostImplClient* host_impl_client) override {
return LayerTreeHostImplForTesting::Create(
test_hooks_, settings(), host_impl_client, task_runner_provider(),
@@ -662,7 +664,7 @@ void LayerTreeTest::PostNextCommitWaitsForActivationToMainThread() {
}
void LayerTreeTest::SetOutputSurfaceOnLayerTreeHost(
- scoped_ptr<OutputSurface> output_surface) {
+ std::unique_ptr<OutputSurface> output_surface) {
if (IsRemoteTest()) {
DCHECK(remote_client_layer_tree_host_);
remote_client_layer_tree_host_->SetOutputSurface(std::move(output_surface));
@@ -671,7 +673,8 @@ void LayerTreeTest::SetOutputSurfaceOnLayerTreeHost(
}
}
-scoped_ptr<OutputSurface> LayerTreeTest::ReleaseOutputSurfaceOnLayerTreeHost() {
+std::unique_ptr<OutputSurface>
+LayerTreeTest::ReleaseOutputSurfaceOnLayerTreeHost() {
if (IsRemoteTest()) {
DCHECK(remote_client_layer_tree_host_);
return remote_client_layer_tree_host_->ReleaseOutputSurface();
@@ -695,7 +698,7 @@ void LayerTreeTest::WillBeginTest() {
void LayerTreeTest::DoBeginTest() {
client_ = LayerTreeHostClientForTesting::Create(this);
- scoped_ptr<FakeExternalBeginFrameSource> external_begin_frame_source;
+ std::unique_ptr<FakeExternalBeginFrameSource> external_begin_frame_source;
if (settings_.use_external_begin_frame_source) {
DCHECK(!IsRemoteTest());
external_begin_frame_source.reset(new FakeExternalBeginFrameSource(
@@ -905,8 +908,8 @@ void LayerTreeTest::RequestNewOutputSurface() {
SetOutputSurfaceOnLayerTreeHost(CreateOutputSurface());
}
-scoped_ptr<OutputSurface> LayerTreeTest::CreateOutputSurface() {
- scoped_ptr<FakeOutputSurface> output_surface = CreateFakeOutputSurface();
+std::unique_ptr<OutputSurface> LayerTreeTest::CreateOutputSurface() {
+ std::unique_ptr<FakeOutputSurface> output_surface = CreateFakeOutputSurface();
DCHECK_EQ(delegating_renderer_,
output_surface->capabilities().delegated_rendering);
output_surface_ = output_surface.get();
@@ -918,7 +921,7 @@ scoped_ptr<OutputSurface> LayerTreeTest::CreateOutputSurface() {
return std::move(output_surface);
}
-scoped_ptr<FakeOutputSurface> LayerTreeTest::CreateFakeOutputSurface() {
+std::unique_ptr<FakeOutputSurface> LayerTreeTest::CreateFakeOutputSurface() {
if (delegating_renderer_)
return FakeOutputSurface::CreateDelegating3d();
else
« no previous file with comments | « cc/test/layer_tree_test.h ('k') | cc/test/ordered_simple_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698