Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3969)

Unified Diff: cc/tiles/picture_layer_tiling_set.cc

Issue 1866203004: Convert //cc from scoped_ptr to std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scopedptrcc: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/picture_layer_tiling_set.h ('k') | cc/tiles/picture_layer_tiling_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/picture_layer_tiling_set.cc
diff --git a/cc/tiles/picture_layer_tiling_set.cc b/cc/tiles/picture_layer_tiling_set.cc
index 2c8e930df3a464727d321f44635d5b884475f100..865ff0976d459f21a5bf049531f430829eb064e9 100644
--- a/cc/tiles/picture_layer_tiling_set.cc
+++ b/cc/tiles/picture_layer_tiling_set.cc
@@ -10,6 +10,7 @@
#include <set>
#include <vector>
+#include "base/memory/ptr_util.h"
#include "cc/playback/raster_source.h"
namespace cc {
@@ -18,8 +19,8 @@ namespace {
class LargestToSmallestScaleFunctor {
public:
- bool operator()(const scoped_ptr<PictureLayerTiling>& left,
- const scoped_ptr<PictureLayerTiling>& right) {
+ bool operator()(const std::unique_ptr<PictureLayerTiling>& left,
+ const std::unique_ptr<PictureLayerTiling>& right) {
return left->contents_scale() > right->contents_scale();
}
};
@@ -33,13 +34,13 @@ inline float LargerRatio(float float1, float float2) {
} // namespace
// static
-scoped_ptr<PictureLayerTilingSet> PictureLayerTilingSet::Create(
+std::unique_ptr<PictureLayerTilingSet> PictureLayerTilingSet::Create(
WhichTree tree,
PictureLayerTilingClient* client,
size_t tiling_interest_area_padding,
float skewport_target_time_in_seconds,
int skewport_extrapolation_limit_in_content_pixels) {
- return make_scoped_ptr(new PictureLayerTilingSet(
+ return base::WrapUnique(new PictureLayerTilingSet(
tree, client, tiling_interest_area_padding,
skewport_target_time_in_seconds,
skewport_extrapolation_limit_in_content_pixels));
@@ -78,10 +79,11 @@ void PictureLayerTilingSet::CopyTilingsAndPropertiesFromPendingTwin(
float contents_scale = pending_twin_tiling->contents_scale();
PictureLayerTiling* this_tiling = FindTilingWithScale(contents_scale);
if (!this_tiling) {
- scoped_ptr<PictureLayerTiling> new_tiling = PictureLayerTiling::Create(
- tree_, contents_scale, raster_source, client_,
- tiling_interest_area_padding_, skewport_target_time_in_seconds_,
- skewport_extrapolation_limit_in_content_pixels_);
+ std::unique_ptr<PictureLayerTiling> new_tiling =
+ PictureLayerTiling::Create(
+ tree_, contents_scale, raster_source, client_,
+ tiling_interest_area_padding_, skewport_target_time_in_seconds_,
+ skewport_extrapolation_limit_in_content_pixels_);
tilings_.push_back(std::move(new_tiling));
this_tiling = tilings_.back().get();
tiling_sort_required = true;
@@ -144,7 +146,7 @@ void PictureLayerTilingSet::UpdateTilingsToCurrentRasterSourceForCommit(
RemoveTilingsAboveScale(maximum_contents_scale);
// Invalidate tiles and update them to the new raster source.
- for (const scoped_ptr<PictureLayerTiling>& tiling : tilings_) {
+ for (const std::unique_ptr<PictureLayerTiling>& tiling : tilings_) {
DCHECK(tree_ != PENDING_TREE || !tiling->has_tiles());
tiling->SetRasterSourceAndResize(raster_source);
@@ -236,7 +238,7 @@ void PictureLayerTilingSet::CleanUpTilings(
void PictureLayerTilingSet::RemoveNonIdealTilings() {
auto to_remove =
std::remove_if(tilings_.begin(), tilings_.end(),
- [](const scoped_ptr<PictureLayerTiling>& t) {
+ [](const std::unique_ptr<PictureLayerTiling>& t) {
return t->resolution() == NON_IDEAL_RESOLUTION;
});
tilings_.erase(to_remove, tilings_.end());
@@ -267,7 +269,7 @@ PictureLayerTiling* PictureLayerTilingSet::AddTiling(
int PictureLayerTilingSet::NumHighResTilings() const {
return std::count_if(tilings_.begin(), tilings_.end(),
- [](const scoped_ptr<PictureLayerTiling>& tiling) {
+ [](const std::unique_ptr<PictureLayerTiling>& tiling) {
return tiling->resolution() == HIGH_RESOLUTION;
});
}
@@ -283,11 +285,11 @@ PictureLayerTiling* PictureLayerTilingSet::FindTilingWithScale(
PictureLayerTiling* PictureLayerTilingSet::FindTilingWithResolution(
TileResolution resolution) const {
- auto iter =
- std::find_if(tilings_.begin(), tilings_.end(),
- [resolution](const scoped_ptr<PictureLayerTiling>& tiling) {
- return tiling->resolution() == resolution;
- });
+ auto iter = std::find_if(
+ tilings_.begin(), tilings_.end(),
+ [resolution](const std::unique_ptr<PictureLayerTiling>& tiling) {
+ return tiling->resolution() == resolution;
+ });
if (iter == tilings_.end())
return nullptr;
return iter->get();
@@ -296,7 +298,7 @@ PictureLayerTiling* PictureLayerTilingSet::FindTilingWithResolution(
void PictureLayerTilingSet::RemoveTilingsBelowScale(float minimum_scale) {
auto to_remove = std::remove_if(
tilings_.begin(), tilings_.end(),
- [minimum_scale](const scoped_ptr<PictureLayerTiling>& tiling) {
+ [minimum_scale](const std::unique_ptr<PictureLayerTiling>& tiling) {
return tiling->contents_scale() < minimum_scale;
});
tilings_.erase(to_remove, tilings_.end());
@@ -305,7 +307,7 @@ void PictureLayerTilingSet::RemoveTilingsBelowScale(float minimum_scale) {
void PictureLayerTilingSet::RemoveTilingsAboveScale(float maximum_scale) {
auto to_remove = std::remove_if(
tilings_.begin(), tilings_.end(),
- [maximum_scale](const scoped_ptr<PictureLayerTiling>& tiling) {
+ [maximum_scale](const std::unique_ptr<PictureLayerTiling>& tiling) {
return tiling->contents_scale() > maximum_scale;
});
tilings_.erase(to_remove, tilings_.end());
@@ -316,11 +318,11 @@ void PictureLayerTilingSet::RemoveAllTilings() {
}
void PictureLayerTilingSet::Remove(PictureLayerTiling* tiling) {
- auto iter =
- std::find_if(tilings_.begin(), tilings_.end(),
- [tiling](const scoped_ptr<PictureLayerTiling>& candidate) {
- return candidate.get() == tiling;
- });
+ auto iter = std::find_if(
+ tilings_.begin(), tilings_.end(),
+ [tiling](const std::unique_ptr<PictureLayerTiling>& candidate) {
+ return candidate.get() == tiling;
+ });
if (iter == tilings_.end())
return;
tilings_.erase(iter);
« no previous file with comments | « cc/tiles/picture_layer_tiling_set.h ('k') | cc/tiles/picture_layer_tiling_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698