Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1866203003: Add UMA metric for Expect CT failure (Closed)

Created:
4 years, 8 months ago by estark
Modified:
4 years, 8 months ago
Reviewers:
Mark P, meacer
CC:
chromium-reviews, asvitkine+watch_chromium.org, certificate-transparency-chrome_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA metric for Expect CT failure When an Expect CT report fails to send, record a UMA histogram with the net error code. BUG=596624 Committed: https://crrev.com/8e872d46c8951a7a8333a9883e6c8bd79b154d34 Cr-Commit-Position: refs/heads/master@{#385915}

Patch Set 1 #

Total comments: 5

Patch Set 2 : DISALLOW_COPY_AND_ASSIGN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -1 line) Patch
M chrome/browser/ssl/chrome_expect_ct_reporter.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 1 3 chunks +91 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
estark
meacer: PTAL?
4 years, 8 months ago (2016-04-07 00:43:33 UTC) #2
meacer
Lgtm modulo comments https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right): https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc#newcode260 chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl { ...
4 years, 8 months ago (2016-04-07 18:12:11 UTC) #3
estark
mpearson: can you please review histograms.xml? Thanks! https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right): https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc#newcode260 chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class TestExpectCTNetworkDelegate ...
4 years, 8 months ago (2016-04-07 18:25:12 UTC) #5
meacer
https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right): https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc#newcode260 chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl { On 2016/04/07 18:25:12, ...
4 years, 8 months ago (2016-04-07 18:32:29 UTC) #6
Mark P
histograms.xml lgtm
4 years, 8 months ago (2016-04-07 21:58:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866203003/20001
4 years, 8 months ago (2016-04-07 22:24:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 23:10:19 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 23:13:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e872d46c8951a7a8333a9883e6c8bd79b154d34
Cr-Commit-Position: refs/heads/master@{#385915}

Powered by Google App Engine
This is Rietveld 408576698