Add UMA metric for Expect CT failure

Add UMA metric for Expect CT failure

When an Expect CT report fails to send, record a UMA histogram with the
net error code.

BUG=596624
Committed: https://crrev.com/8e872d46c8951a7a8333a9883e6c8bd79b154d34
Cr-Commit-Position: refs/heads/master@{#385915}

[estark, 2016-04-07 00:43:32]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2016-04-07 00:43:33]

meacer: PTAL?

[meacer, 2016-04-07 18:12:11]

Lgtm modulo comments

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right):

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class
TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl {
Seems like this should derive from net::NetworkDelegate instead.

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:314:
content::TestBrowserThreadBundle thread_bundle_;
DISALLOW_COPY_AND_ASSIGN

[estark, 2016-04-07 18:25:09]

estark@chromium.org changed reviewers:
+ mpearson@chromium.org

[estark, 2016-04-07 18:25:12]

mpearson: can you please review histograms.xml? Thanks!

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right):

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class
TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl {
On 2016/04/07 18:12:11, Mustafa Emre Acer wrote:
> Seems like this should derive from net::NetworkDelegate instead.

Hmm, I don't think so. I don't quite understand why they are separate, but
NetworkDelegateImpl has lots of subclasses outside of //net (including
ChromeNetworkDelegate) and NetworkDelegate has none.

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:314:
content::TestBrowserThreadBundle thread_bundle_;
On 2016/04/07 18:12:11, Mustafa Emre Acer wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

[meacer, 2016-04-07 18:32:29]

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc (right):

https://codereview.chromium.org/1866203003/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc:260: class
TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl {
On 2016/04/07 18:25:12, estark wrote:
> On 2016/04/07 18:12:11, Mustafa Emre Acer wrote:
> > Seems like this should derive from net::NetworkDelegate instead.
> 
> Hmm, I don't think so. I don't quite understand why they are separate, but
> NetworkDelegateImpl has lots of subclasses outside of //net (including
> ChromeNetworkDelegate) and NetworkDelegate has none.

Ok never mind. Looks like NetworkDelegateImpl is just providing default
implementations for NetworkDelegate.

[Mark P, 2016-04-07 21:58:44]

histograms.xml lgtm

[estark, 2016-04-07 22:24:04]

The CQ bit was checked by estark@chromium.org

[estark, 2016-04-07 22:24:05]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/1866203003/#ps20001
(title: "DISALLOW_COPY_AND_ASSIGN")

[commit-bot: I haz the power, 2016-04-07 22:24:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866203003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866203003/20001

[commit-bot: I haz the power, 2016-04-07 23:10:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 23:13:45]

Description was changed from

==========
Add UMA metric for Expect CT failure

When an Expect CT report fails to send, record a UMA histogram with the
net error code.

BUG=596624
==========

to

==========
Add UMA metric for Expect CT failure

When an Expect CT report fails to send, record a UMA histogram with the
net error code.

BUG=596624

Committed: https://crrev.com/8e872d46c8951a7a8333a9883e6c8bd79b154d34
Cr-Commit-Position: refs/heads/master@{#385915}
==========

[commit-bot: I haz the power, 2016-04-07 23:13:46]

Patchset 2 (id:??) landed as
https://crrev.com/8e872d46c8951a7a8333a9883e6c8bd79b154d34
Cr-Commit-Position: refs/heads/master@{#385915}