Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1866153003: Use "linear" as the default easing for neutral keyframes in element.animate() (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)
Modified:
4 years, 8 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "linear" as the default easing for neutral keyframes in element.animate() By explicitly setting "linear" as the default keyframe easing when using element.animate() we don't accidentally start compositor animations using their default of "ease". BUG=601407 Committed: https://crrev.com/99d5466b3824d1170c02088d7c38e2ca1e53c95b Cr-Commit-Position: refs/heads/master@{#387537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
alancutter (OOO until 2018)
4 years, 8 months ago (2016-04-07 12:35:04 UTC) #2
alancutter (OOO until 2018)
ericwilligers: Poke.
4 years, 8 months ago (2016-04-13 05:39:05 UTC) #4
Eric Willigers
How would we add a regression test?
4 years, 8 months ago (2016-04-13 06:01:26 UTC) #5
alancutter (OOO until 2018)
On 2016/04/13 at 06:01:26, ericwilligers wrote: > How would we add a regression test? See ...
4 years, 8 months ago (2016-04-14 00:28:14 UTC) #6
Eric Willigers
lgtm
4 years, 8 months ago (2016-04-15 00:33:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866153003/1
4 years, 8 months ago (2016-04-15 03:46:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 04:51:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 04:53:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99d5466b3824d1170c02088d7c38e2ca1e53c95b
Cr-Commit-Position: refs/heads/master@{#387537}

Powered by Google App Engine
This is Rietveld 408576698