Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1866113002:
Fix Chrome OS Login status area layout. (Closed)
DescriptionFix Chrome OS Login status area layout.
Let ShelfLayoutManager perform layout before a shelf exists.
Fixes a regression from https://codereview.chromium.org/1851883002
Generalize NoSessionRootWindowControllerTest.Event
(ensure event handler(s) exists, not necessarily a single handler)
(not sure why it's only now finding the status area as a handler...)
Tested locally with:
chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo
BUG=600911
TEST=Status area is placed on bottom right during cros login
R=sky@chromium.org
Committed: https://crrev.com/f9da4d84543481779c974d26b8c3536fdd0249e5
Cr-Commit-Position: refs/heads/master@{#385812}
Patch Set 1 #Patch Set 2 : Update unit test. #
Messages
Total messages: 19 (10 generated)
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866113002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=jamescook@chromium.org ========== to ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=jamescook@chromium.org ==========
Description was changed from ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=jamescook@chromium.org ========== to ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org ==========
msw@chromium.org changed reviewers: + sky@chromium.org - jamescook@chromium.org
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Hey Scott, please take a look; thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866113002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM
The CQ bit was checked by msw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866113002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org ========== to ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org ========== to ========== Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG=600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org Committed: https://crrev.com/f9da4d84543481779c974d26b8c3536fdd0249e5 Cr-Commit-Position: refs/heads/master@{#385812} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f9da4d84543481779c974d26b8c3536fdd0249e5 Cr-Commit-Position: refs/heads/master@{#385812} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
