extensions/renderer/dispatcher.cc - Issue 1866103002: [Extensions] Expand bindings access checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1866103002: [Extensions] Expand bindings access checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc ('K') | « extensions/renderer/api_definitions_natives.cc ('k') | extensions/renderer/display_source_custom_bindings.cc » ('j') | extensions/renderer/object_backed_native_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index f841ee985fcbe29df8d1241035d3182536c324e1..552a707fa2e2039e9c3d53aaa5c6d38b26048001 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -70,13 +70,10 @@

#include "extensions/renderer/extensions_renderer_client.h"

#include "extensions/renderer/file_system_natives.h"

#include "extensions/renderer/guest_view/guest_view_internal_custom_bindings.h"

-#include "extensions/renderer/i18n_custom_bindings.h"

#include "extensions/renderer/id_generator_custom_bindings.h"

-#include "extensions/renderer/lazy_background_page_native_handler.h"

#include "extensions/renderer/logging_native_handler.h"

#include "extensions/renderer/messaging_bindings.h"

#include "extensions/renderer/module_system.h"

-#include "extensions/renderer/print_native_handler.h"

#include "extensions/renderer/process_info_native_handler.h"

#include "extensions/renderer/render_frame_observer_natives.h"

#include "extensions/renderer/renderer_extension_registry.h"

@@ -828,15 +825,10 @@ void Dispatcher::RegisterNativeHandlers(ModuleSystem* module_system,

module_system->RegisterNativeHandler(

"chrome", scoped_ptr<NativeHandler>(new ChromeNativeHandler(context)));

module_system->RegisterNativeHandler(

- "lazy_background_page",

- scoped_ptr<NativeHandler>(new LazyBackgroundPageNativeHandler(context)));

- module_system->RegisterNativeHandler(

"logging", scoped_ptr<NativeHandler>(new LoggingNativeHandler(context)));

module_system->RegisterNativeHandler("schema_registry",

v8_schema_registry->AsNativeHandler());

module_system->RegisterNativeHandler(

- "print", scoped_ptr<NativeHandler>(new PrintNativeHandler(context)));

- module_system->RegisterNativeHandler(

"test_features",

scoped_ptr<NativeHandler>(new TestFeaturesNativeHandler(context)));

module_system->RegisterNativeHandler(

@@ -899,8 +891,6 @@ void Dispatcher::RegisterNativeHandlers(ModuleSystem* module_system,

scoped_ptr<NativeHandler>(

new GuestViewInternalCustomBindings(context)));

module_system->RegisterNativeHandler(

- "i18n", scoped_ptr<NativeHandler>(new I18NCustomBindings(context)));

- module_system->RegisterNativeHandler(

"id_generator",

scoped_ptr<NativeHandler>(new IdGeneratorCustomBindings(context)));

module_system->RegisterNativeHandler(