Issue 18661: Experimental: defer the per-function and per-loop calls to the runtime...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18661: Experimental: defer the per-function and per-loop calls to the runtime... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: defer the per-function and per-loop calls to the runtime on a failed stack check. Committed: http://code.google.com/p/v8/source/detail?r=1129

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
	M	src/codegen-ia32.cc	View		4 chunks	+28 lines, -11 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/18661/diff/1/2 File src/codegen-ia32.cc (right): http://codereview.chromium.org/18661/diff/1/2#newcode1342 Line 1342: StackCheckStub stub; Maybe move this to just ...

11 years, 11 months ago (2009-01-22 14:04:46 UTC) #2

Kevin Millikin (Chromium)

11 years, 11 months ago (2009-01-22 14:07:50 UTC) #3

http://codereview.chromium.org/18661/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18661/diff/1/2#newcode1342
Line 1342: StackCheckStub stub;
On 2009/01/22 14:04:46, Kasper Lund wrote:
> Maybe move this to just before it's used (CallStub)?

NP.

Expand Messages | Collapse Messages