Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1866083003: [Binding][Performance] Add performance tests for serialization in BlinkBinding (Closed)

Created:
4 years, 8 months ago by peria
Modified:
4 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance tests for serialization in BlinkBinding This CL add performance tests to measure time to serialize following items. In this CL, I added four type specific tests to factor out what can be the bottleneck of serializations. - a long string : serialize a large size native instance - a long array : serialize an array with many small elements - a nested array : serialize many arrays in chain - a map : serialize a map whose keys are not ignorable BUG=148757 TEST=tools/perf/run_benchmark run blink_perf.bindings Committed: https://crrev.com/ae459e084f702f116959a296e30cc6550ea84d24 Cr-Commit-Position: refs/heads/master@{#385703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A third_party/WebKit/PerformanceTests/Bindings/resources/worker.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Bindings/serialize-array.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Bindings/serialize-long-string.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Bindings/serialize-map.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Bindings/serialize-nested-array.html View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
peria
PTL
4 years, 8 months ago (2016-04-07 06:22:04 UTC) #4
haraken
LGTM Another interesting test case would be to send a ton of small postMessages.
4 years, 8 months ago (2016-04-07 07:21:51 UTC) #5
peria
On 2016/04/07 07:21:51, haraken wrote: > LGTM > > Another interesting test case would be ...
4 years, 8 months ago (2016-04-07 07:26:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866083003/1
4 years, 8 months ago (2016-04-07 07:27:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 10:00:23 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 10:01:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae459e084f702f116959a296e30cc6550ea84d24
Cr-Commit-Position: refs/heads/master@{#385703}

Powered by Google App Engine
This is Rietveld 408576698