[Findit] Move third-party libs to a sub directory and use appengine_config.py to add them at runtim…

[Findit] Move third-party libs to a sub directory and use appengine_config.py to add them at runtime.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/3deb9a2fa1d1e0fb17f231d87198d802861bf48c

[stgao, 2016-04-06 18:12:51]

The CQ bit was checked by stgao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 18:13:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866053002/1

[stgao, 2016-04-06 18:13:41]

stgao@chromium.org changed reviewers:
+ lijeffrey@chromium.org

[stgao, 2016-04-06 18:13:42]

ptal when you have a chance.

[stgao, 2016-04-06 18:26:37]

stgao@chromium.org changed reviewers:
+ pgervais@chromium.org

[stgao, 2016-04-06 18:26:37]

+pgervais, do you mind a review of the change to
appengine_module/expect_tests_pretest.py? It seems to be loaded per test, is it
correct?

BTW, the CQ dry-run passed.

[lijeffrey, 2016-04-06 18:40:29]

lgtm

[commit-bot: I haz the power, 2016-04-06 19:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 19:48:47]

Dry run: This issue passed the CQ dry run.

[pgervais, 2016-04-06 21:52:38]

lgtm, though I would avoid making appengine_config.py have a side effect. Some
programs will want to inspect the content and will end up modifying their path
:-/

I'd be better to do something like 

import appengine_config
appengine_config.setup()

[stgao, 2016-04-06 23:08:12]

On 2016/04/06 21:52:38, pgervais wrote:
> lgtm, though I would avoid making appengine_config.py have a side effect. Some
> programs will want to inspect the content and will end up modifying their path
> :-/
> 
> I'd be better to do something like 
> 
> import appengine_config
> appengine_config.setup()

Per discussion offline, I will leave this CL as is, because the purpose of the
appengine_config.py is to have a side effect before any code of an app is run,
according to
https://cloud.google.com/appengine/docs/python/tools/appengineconfig

[stgao, 2016-04-06 23:08:20]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:08:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866053002/1

[commit-bot: I haz the power, 2016-04-06 23:10:45]

Description was changed from

==========
[Findit] Move third-party libs to a sub directory and use appengine_config.py to
add them at runtime.

BUG=
==========

to

==========
[Findit] Move third-party libs to a sub directory and use appengine_config.py to
add them at runtime.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/3deb9a2fa1d1e0fb17f231d87198d...
==========

[commit-bot: I haz the power, 2016-04-06 23:10:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/3deb9a2fa1d1e0fb17f231d87198d...