Chromium Code Reviews| Index: cc/tiles/tile_manager_unittest.cc |
| diff --git a/cc/tiles/tile_manager_unittest.cc b/cc/tiles/tile_manager_unittest.cc |
| index 18cdcb834bf49190ebd4d9204ddcb76a66fbc7ee..fd5745ac98bb8f7f410a7241ae18c78a86d30fdf 100644 |
| --- a/cc/tiles/tile_manager_unittest.cc |
| +++ b/cc/tiles/tile_manager_unittest.cc |
| @@ -1908,22 +1908,7 @@ TEST_F(ActivationTasksDoNotBlockReadyToDrawTest, |
| run_loop.Run(); |
| } |
| -// Fake TileTaskManager that just cancels all scheduled tasks immediately. |
| -class CancellingTileTaskManager : public FakeTileTaskManagerImpl { |
| - public: |
| - CancellingTileTaskManager() {} |
| - ~CancellingTileTaskManager() override {} |
| - |
| - void ScheduleTasks(TaskGraph* graph) override { |
| - // Just call CompleteOnOriginThread on each item in the queue. As none of |
| - // these items have run yet, they will be treated as cancelled tasks. |
| - for (const auto& node : graph->nodes) { |
| - static_cast<TileTask*>(node.task)->CompleteOnOriginThread( |
| - raster_buffer_provider_.get()); |
| - } |
| - } |
| - void CheckForCompletedTasks() override {} |
| -}; |
| +using CancellingTileTaskManager = FakeTileTaskManagerImpl; |
|
vmpstr
2016/05/21 00:02:14
Can you just rename CancellingTileTaskManager to
prashant.n
2016/05/21 00:51:45
Now if task has be to canceled, it's explicit. So
|
| class PartialRasterTileManagerTest : public TileManagerTest { |
| public: |
| @@ -2017,17 +2002,6 @@ class VerifyResourceContentIdTileTaskManager : public FakeTileTaskManagerImpl { |
| new VerifyResourceContentIdRasterBufferProvider( |
| expected_resource_id))) {} |
| ~VerifyResourceContentIdTileTaskManager() override {} |
| - |
| - void ScheduleTasks(TaskGraph* graph) override { |
| - for (const auto& node : graph->nodes) { |
| - TileTask* task = static_cast<TileTask*>(node.task); |
| - // Triggers a call to AcquireBufferForRaster. |
| - task->ScheduleOnOriginThread(raster_buffer_provider_.get()); |
| - // Calls TileManager as though task was cancelled. |
| - task->CompleteOnOriginThread(raster_buffer_provider_.get()); |
| - } |
| - } |
| - void CheckForCompletedTasks() override {} |
| }; |
| // Runs a test to ensure that partial raster is either enabled or disabled, |