Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: cc/tiles/software_image_decode_controller.cc

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wip - fixed few unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/software_image_decode_controller.cc
diff --git a/cc/tiles/software_image_decode_controller.cc b/cc/tiles/software_image_decode_controller.cc
index 3f52af5c1989e40e5c5d3064109bd7d65b023a7b..abdb60b8013e392fd8eeed759bc949e45b1787cb 100644
--- a/cc/tiles/software_image_decode_controller.cc
+++ b/cc/tiles/software_image_decode_controller.cc
@@ -64,7 +64,9 @@ class ImageDecodeTaskImpl : public ImageDecodeTask {
image_key_(image_key),
image_(image),
image_ref_(skia::SharePtr(image.image())),
- source_prepare_tiles_id_(source_prepare_tiles_id) {}
+ source_prepare_tiles_id_(source_prepare_tiles_id) {
+ SetTaskTypeId(kImageDecodeTaskTypeId);
+ }
// Overridden from Task:
void RunOnWorkerThread() override {
@@ -76,22 +78,17 @@ class ImageDecodeTaskImpl : public ImageDecodeTask {
controller_->DecodeImage(image_key_, image_);
}
- // Overridden from TileTask:
- void ScheduleOnOriginThread(TileTaskClient* client) override {}
- void CompleteOnOriginThread(TileTaskClient* client) override {
- controller_->RemovePendingTask(image_key_);
- }
-
protected:
~ImageDecodeTaskImpl() override {}
- private:
+ public:
SoftwareImageDecodeController* controller_;
SoftwareImageDecodeController::ImageKey image_key_;
DrawImage image_;
skia::RefPtr<const SkImage> image_ref_;
uint64_t source_prepare_tiles_id_;
+ private:
DISALLOW_COPY_AND_ASSIGN(ImageDecodeTaskImpl);
};
@@ -630,6 +627,12 @@ void SoftwareImageDecodeController::DrawWithImageFinished(
SanityCheckState(__LINE__, false);
}
+void SoftwareImageDecodeController::CompleteTask(Task* task) {
+ ImageDecodeTaskImpl* decode_task = static_cast<ImageDecodeTaskImpl*>(task);
+ DCHECK(decode_task);
+ RemovePendingTask(decode_task->image_key_);
+}
+
void SoftwareImageDecodeController::RefAtRasterImage(const ImageKey& key) {
TRACE_EVENT1("disabled-by-default-cc.debug",
"SoftwareImageDecodeController::RefAtRasterImage", "key",

Powered by Google App Engine
This is Rietveld 408576698