Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: cc/tiles/tile_task_manager.h

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/tile_task_manager.h
diff --git a/cc/tiles/tile_task_manager.h b/cc/tiles/tile_task_manager.h
index e670b415602ad33e4e75111e982e5d843fcd7447..478d2ad4b8aa85c978c8f7bac382a5886fe2e93f 100644
--- a/cc/tiles/tile_task_manager.h
+++ b/cc/tiles/tile_task_manager.h
@@ -13,9 +13,9 @@
namespace cc {
// This interface provides the wrapper over TaskGraphRunner for scheduling and
-// collecting tasks. The client can call CheckForCompletedTasks() at any time to
-// process all completed tasks at the moment that have finished running or
-// cancelled.
+// collecting tasks. The client can call CollectCompletedTasks() at any time
+// for processing all completed tasks at the moment that have finished running
+// or cancelled.
class CC_EXPORT TileTaskManager {
public:
TileTaskManager();
@@ -28,11 +28,10 @@ class CC_EXPORT TileTaskManager {
// ScheduleTasks().
virtual void ScheduleTasks(TaskGraph* graph) = 0;
- // Check for completed tasks and dispatch reply callbacks.
- virtual void CheckForCompletedTasks() = 0;
+ // Collect completed tasks.
+ virtual void CollectCompletedTasks(Task::Vector* completed_tasks) = 0;
- // Shutdown after canceling all previously scheduled tasks. Reply callbacks
- // are still guaranteed to run when CheckForCompletedTasks() is called.
+ // Shutdown after canceling all previously scheduled tasks.
virtual void Shutdown() = 0;
// Get RasterBufferProvider.
@@ -49,7 +48,7 @@ class CC_EXPORT TileTaskManagerImpl : public TileTaskManager {
// Overridden from TileTaskManager:
void ScheduleTasks(TaskGraph* graph) override;
- void CheckForCompletedTasks() override;
+ void CollectCompletedTasks(Task::Vector* completed_tasks) override;
void Shutdown() override;
RasterBufferProvider* GetRasterBufferProvider() const override;
@@ -61,7 +60,6 @@ class CC_EXPORT TileTaskManagerImpl : public TileTaskManager {
std::unique_ptr<RasterBufferProvider> raster_buffer_provider_;
TaskGraphRunner* task_graph_runner_;
const NamespaceToken namespace_token_;
- Task::Vector completed_tasks_;
private:
DISALLOW_COPY_AND_ASSIGN(TileTaskManagerImpl);

Powered by Google App Engine
This is Rietveld 408576698