cc/raster/task_graph_work_queue.cc - Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/raster/task_graph_work_queue.cc

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/raster/task_graph_work_queue.cc

diff --git a/cc/raster/task_graph_work_queue.cc b/cc/raster/task_graph_work_queue.cc

index 807539db8e49252a01c6b346a625525c7d326d85..291a06f46510d16095a902816e00aaa5bdb23c34 100644

--- a/cc/raster/task_graph_work_queue.cc

+++ b/cc/raster/task_graph_work_queue.cc

@@ -189,8 +189,8 @@ void TaskGraphWorkQueue::ScheduleTasks(NamespaceToken token, TaskGraph* graph) {

it != graph->nodes.end(); ++it) {

TaskGraph::Node& node = *it;

- // Skip if already finished running task.

- if (node.task->state().IsFinished())

+ // Skip if already finished or completed.

+ if (node.task->state().IsFinished() || node.task->state().IsCompleted())

continue;

// Skip if already running.

« cc/raster/task_graph_runner_perftest.cc ('K') | « cc/raster/task_graph_runner_perftest.cc ('k') | cc/raster/tile_task.h » ('j') | cc/raster/tile_task.h » ('J')