Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2773)

Unified Diff: cc/test/fake_tile_manager.cc

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wip Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/fake_tile_manager.cc
diff --git a/cc/test/fake_tile_manager.cc b/cc/test/fake_tile_manager.cc
index 77b9b0dfbcf2d46359d3ad824ee22dc280a5e615..2573a3cdf7f5fbf0ee336290285e31b8fe267e84 100644
--- a/cc/test/fake_tile_manager.cc
+++ b/cc/test/fake_tile_manager.cc
@@ -26,22 +26,16 @@ class FakeTileTaskRunnerImpl : public TileTaskRunner, public TileTaskClient {
void ScheduleTasks(TaskGraph* graph) override {
for (const auto& node : graph->nodes) {
RasterTask* task = static_cast<RasterTask*>(node.task);
-
- task->WillSchedule();
- task->ScheduleOnOriginThread(this);
- task->DidSchedule();
-
completed_tasks_.push_back(task);
}
}
- void CheckForCompletedTasks() override {
+ void CollectCompletedTasks(Task::Vector* completed_tasks) override {
+ // TODO(prashant.n): Modify the function definition to make it analogous
+ // with other overridden definitions of CollectCompletedTasks.
for (RasterTask::Vector::iterator it = completed_tasks_.begin();
it != completed_tasks_.end();
++it) {
RasterTask* task = it->get();
-
- task->WillComplete();
- task->CompleteOnOriginThread(this);
task->DidComplete();
}
completed_tasks_.clear();
@@ -53,6 +47,8 @@ class FakeTileTaskRunnerImpl : public TileTaskRunner, public TileTaskClient {
return ResourceFormatRequiresSwizzle(GetResourceFormat(must_support_alpha));
}
+ TileTaskClient* AsTileTaskClient() override { return this; }
+
// Overridden from TileTaskClient:
scoped_ptr<RasterBuffer> AcquireBufferForRaster(
const Resource* resource,

Powered by Google App Engine
This is Rietveld 408576698