Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: cc/test/fake_tile_task_manager.cc

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/test/fake_tile_task_manager.h ('k') | cc/test/task_graph_runner_test_template.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/test/fake_tile_task_manager.h" 5 #include "cc/test/fake_tile_task_manager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 8
9 namespace cc { 9 namespace cc {
10 10
11 FakeTileTaskManagerImpl::FakeTileTaskManagerImpl() 11 FakeTileTaskManagerImpl::FakeTileTaskManagerImpl()
12 : raster_buffer_provider_(base::WrapUnique<RasterBufferProvider>( 12 : raster_buffer_provider_(base::WrapUnique<RasterBufferProvider>(
13 new FakeRasterBufferProviderImpl)) {} 13 new FakeRasterBufferProviderImpl)) {}
14 14
15 FakeTileTaskManagerImpl::FakeTileTaskManagerImpl( 15 FakeTileTaskManagerImpl::FakeTileTaskManagerImpl(
16 std::unique_ptr<RasterBufferProvider> raster_buffer_provider) 16 std::unique_ptr<RasterBufferProvider> raster_buffer_provider)
17 : raster_buffer_provider_(std::move(raster_buffer_provider)) {} 17 : raster_buffer_provider_(std::move(raster_buffer_provider)) {}
18 18
19 FakeTileTaskManagerImpl::~FakeTileTaskManagerImpl() {} 19 FakeTileTaskManagerImpl::~FakeTileTaskManagerImpl() {
20 DCHECK_EQ(0u, completed_tasks_.size());
21 }
20 22
21 void FakeTileTaskManagerImpl::ScheduleTasks(TaskGraph* graph) { 23 void FakeTileTaskManagerImpl::ScheduleTasks(TaskGraph* graph) {
22 for (const auto& node : graph->nodes) { 24 for (const auto& node : graph->nodes) {
23 TileTask* task = static_cast<TileTask*>(node.task); 25 TileTask* task = static_cast<TileTask*>(node.task);
24 26 // Cancel the task and append to |completed_tasks_|.
25 task->WillSchedule(); 27 task->state().DidCancel();
26 task->ScheduleOnOriginThread(raster_buffer_provider_.get());
27 task->DidSchedule();
28
29 completed_tasks_.push_back(task); 28 completed_tasks_.push_back(task);
30 } 29 }
31 } 30 }
32 31
33 void FakeTileTaskManagerImpl::CheckForCompletedTasks() { 32 void FakeTileTaskManagerImpl::CheckForCompletedTasks() {
34 for (Task::Vector::iterator it = completed_tasks_.begin(); 33 for (auto& task : completed_tasks_) {
35 it != completed_tasks_.end(); ++it) { 34 DCHECK(task->state().IsFinished() || task->state().IsCanceled());
36 TileTask* task = static_cast<TileTask*>(it->get()); 35 TileTask* tile_task = static_cast<TileTask*>(task.get());
36 tile_task->OnTaskCompleted();
37 }
37 38
38 task->WillComplete();
39 task->CompleteOnOriginThread(raster_buffer_provider_.get());
40 task->DidComplete();
41 }
42 completed_tasks_.clear(); 39 completed_tasks_.clear();
43 } 40 }
44 41
45 void FakeTileTaskManagerImpl::Shutdown() {} 42 void FakeTileTaskManagerImpl::Shutdown() {}
46 43
47 RasterBufferProvider* FakeTileTaskManagerImpl::GetRasterBufferProvider() const { 44 RasterBufferProvider* FakeTileTaskManagerImpl::GetRasterBufferProvider() const {
48 return raster_buffer_provider_.get(); 45 return raster_buffer_provider_.get();
49 } 46 }
50 47
51 } // namespace cc 48 } // namespace cc
OLDNEW
« no previous file with comments | « cc/test/fake_tile_task_manager.h ('k') | cc/test/task_graph_runner_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698