cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread().

cc/tiles/tile_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 1890 matching lines @@
 
   // The first task to run should be ReadyToDraw (this should not be blocked by
   // the tasks required for activation).
   base::RunLoop run_loop;
   EXPECT_CALL(*host_impl_, NotifyReadyToDraw())
       .WillOnce(testing::Invoke([&run_loop]() { run_loop.Quit(); }));
   GetSynchronousTaskGraphRunner()->RunSingleTaskForTesting();
   run_loop.Run();
 }
 
-// Fake TileTaskManager that just cancels all scheduled tasks immediately.
-class CancellingTileTaskManager : public FakeTileTaskManagerImpl {
- public:
-  CancellingTileTaskManager() {}
-  ~CancellingTileTaskManager() override {}
-
-  void ScheduleTasks(TaskGraph* graph) override {
-    // Just call CompleteOnOriginThread on each item in the queue. As none of
-    // these items have run yet, they will be treated as cancelled tasks.
-    for (const auto& node : graph->nodes) {
-      static_cast<TileTask*>(node.task)->CompleteOnOriginThread(
-          raster_buffer_provider_.get());
-    }
-  }
-  void CheckForCompletedTasks() override {}
-};
+using CancellingTileTaskManager = FakeTileTaskManagerImpl;

[vmpstr, 2016/05/21 00:02:14]

Can you just rename CancellingTileTaskManager  to FakeTileTaskManagerImpl. Also,
are the tests testing the same thing now? I guess tasks are implicitly cancelled
unless run?

[prashant.n, 2016/05/21 00:51:45]

Now if task has be to canceled, it's explicit. So base class
FakeTileTaskManagerImpl does the same stuff.

 
 class PartialRasterTileManagerTest : public TileManagerTest {
  public:
   void CustomizeSettings(LayerTreeSettings* settings) override {
     settings->use_partial_raster = true;
   }
 };
 
 // Ensures that if a raster task is cancelled, it gets returned to the resource
 // pool with an invalid content ID, not with its invalidated content ID.
@@ skipping 73 matching lines @@
   uint64_t expected_resource_id_;
 };
 
 class VerifyResourceContentIdTileTaskManager : public FakeTileTaskManagerImpl {
  public:
   explicit VerifyResourceContentIdTileTaskManager(uint64_t expected_resource_id)
       : FakeTileTaskManagerImpl(base::WrapUnique<RasterBufferProvider>(
             new VerifyResourceContentIdRasterBufferProvider(
                 expected_resource_id))) {}
   ~VerifyResourceContentIdTileTaskManager() override {}
-
-  void ScheduleTasks(TaskGraph* graph) override {
-    for (const auto& node : graph->nodes) {
-      TileTask* task = static_cast<TileTask*>(node.task);
-      // Triggers a call to AcquireBufferForRaster.
-      task->ScheduleOnOriginThread(raster_buffer_provider_.get());
-      // Calls TileManager as though task was cancelled.
-      task->CompleteOnOriginThread(raster_buffer_provider_.get());
-    }
-  }
-  void CheckForCompletedTasks() override {}
 };
 
 // Runs a test to ensure that partial raster is either enabled or disabled,
 // depending on |partial_raster_enabled|'s value. Takes ownership of host_impl
 // so that cleanup order can be controlled.
 void RunPartialRasterCheck(std::unique_ptr<LayerTreeHostImpl> host_impl,
                            bool partial_raster_enabled) {
   // Pick arbitrary IDs - they don't really matter as long as they're constant.
   const int kLayerId = 7;
   const uint64_t kInvalidatedId = 43;
@@ skipping 57 matching lines @@
 
 // Ensures that the tile manager does not attempt to reuse tiles when partial
 // raster is disabled.
 TEST_F(TileManagerTest, PartialRasterSuccessfullyDisabled) {
   RunPartialRasterCheck(std::move(host_impl_),
                         false /* partial_raster_enabled */);
 }
 
 }  // namespace
 }  // namespace cc