Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: cc/raster/task.cc

Issue 1866043006: cc: Remove ScheduleOnOriginThread() and CompleteOnOriginThread(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/raster/task.h" 5 #include "cc/raster/task.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace cc { 9 namespace cc {
10 10
11 TaskState::TaskState() : value_(Value::NEW) {} 11 TaskState::TaskState() : value_(Value::NEW) {}
12 12
13 TaskState::~TaskState() { 13 TaskState::~TaskState() {
14 DCHECK(value_ != Value::RUNNING) 14 DCHECK(value_ != Value::RUNNING)
15 << "Running task should never get destroyed."; 15 << "Running task should never get destroyed.";
16 DCHECK(value_ == Value::NEW || value_ == Value::FINISHED || 16 DCHECK(value_ == Value::NEW || value_ == Value::COMPLETED)
17 value_ == Value::CANCELED) 17 << "Task, if scheduled, should get concluded in COMPLETED state.";
18 << "Task, if scheduled, should get concluded either in FINISHED or "
19 "CANCELED state.";
20 } 18 }
21 19
22 bool TaskState::IsScheduled() const { 20 bool TaskState::IsScheduled() const {
23 return value_ == Value::SCHEDULED; 21 return value_ == Value::SCHEDULED;
24 } 22 }
25 23
26 bool TaskState::IsRunning() const { 24 bool TaskState::IsRunning() const {
27 return value_ == Value::RUNNING; 25 return value_ == Value::RUNNING;
28 } 26 }
27
29 bool TaskState::IsFinished() const { 28 bool TaskState::IsFinished() const {
30 return value_ == Value::FINISHED; 29 return value_ == Value::FINISHED;
31 } 30 }
31
32 bool TaskState::IsCanceled() const { 32 bool TaskState::IsCanceled() const {
33 return value_ == Value::CANCELED; 33 return value_ == Value::CANCELED;
34 } 34 }
35 35
36 bool TaskState::IsCompleted() const {
37 return value_ == Value::COMPLETED;
38 }
39
36 void TaskState::Reset() { 40 void TaskState::Reset() {
37 value_ = Value::NEW; 41 value_ = Value::NEW;
38 } 42 }
39 43
40 void TaskState::DidSchedule() { 44 void TaskState::DidSchedule() {
41 DCHECK(value_ == Value::NEW) 45 DCHECK(value_ == Value::NEW)
42 << "Task should be in NEW state to get scheduled."; 46 << "Task should be in NEW state to get scheduled.";
43 value_ = Value::SCHEDULED; 47 value_ = Value::SCHEDULED;
44 } 48 }
45 49
46 void TaskState::DidStart() { 50 void TaskState::DidStart() {
47 DCHECK(value_ == Value::SCHEDULED) 51 DCHECK(value_ == Value::SCHEDULED)
48 << "Task should be only in SCHEDULED state to start, that is it should " 52 << "Task should be only in SCHEDULED state to start, that is it should "
49 "not be started or finished."; 53 "not be started or finished.";
50 value_ = Value::RUNNING; 54 value_ = Value::RUNNING;
51 } 55 }
52 56
53 void TaskState::DidFinish() { 57 void TaskState::DidFinish() {
54 DCHECK(value_ == Value::RUNNING) 58 DCHECK(value_ == Value::RUNNING)
55 << "Task should be running and not finished earlier."; 59 << "Task should be running and not finished earlier.";
56 value_ = Value::FINISHED; 60 value_ = Value::FINISHED;
57 } 61 }
58 62
59 void TaskState::DidCancel() { 63 void TaskState::DidCancel() {
60 DCHECK(value_ == Value::NEW || value_ == Value::SCHEDULED) 64 DCHECK(value_ == Value::NEW || value_ == Value::SCHEDULED)
61 << "Task should be scheduled and not running to get canceled."; 65 << "Task should be scheduled and not running to get canceled.";
62 value_ = Value::CANCELED; 66 value_ = Value::CANCELED;
63 } 67 }
64 68
69 void TaskState::DidComplete() {
70 DCHECK(value_ == Value::FINISHED || value_ == Value::CANCELED)
71 << "Task should be finished or cancelled to get completed. Unscheduled "
72 "tasks cannot be completed.";
73 value_ = Value::COMPLETED;
74 }
75
65 Task::Task() {} 76 Task::Task() {}
66 77
67 Task::~Task() {} 78 Task::~Task() {}
68 79
69 TaskGraph::TaskGraph() {} 80 TaskGraph::TaskGraph() {}
70 81
71 TaskGraph::TaskGraph(const TaskGraph& other) = default; 82 TaskGraph::TaskGraph(const TaskGraph& other) = default;
72 83
73 TaskGraph::~TaskGraph() {} 84 TaskGraph::~TaskGraph() {}
74 85
75 void TaskGraph::Swap(TaskGraph* other) { 86 void TaskGraph::Swap(TaskGraph* other) {
76 nodes.swap(other->nodes); 87 nodes.swap(other->nodes);
77 edges.swap(other->edges); 88 edges.swap(other->edges);
78 } 89 }
79 90
80 void TaskGraph::Reset() { 91 void TaskGraph::Reset() {
81 nodes.clear(); 92 nodes.clear();
82 edges.clear(); 93 edges.clear();
83 } 94 }
84 95
85 } // namespace cc 96 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698