Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1866033002: Add an annotation to the history.g.c link in ClearBrowsingDataPreferences (Closed)

Created:
4 years, 8 months ago by msramek
Modified:
4 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an annotation to the history.g.c link in ClearBrowsingDataPreferences The history.google.com link referenced from the ClearBrowserDataHandler on desktop adds the parameter utm_source=chrome_cbd to determine that the source is the Clear Browsing Data dialog. This CL adds the same parameter to the link in ClearBrowsingDataPreferences on Android. BUG=595332 Committed: https://crrev.com/59a92a51fe90d2ab15d05ed8caaae769b2c2e13a Cr-Commit-Position: refs/heads/master@{#385534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
msramek
Hi again Dan, please have a look at this tiny CL as well :) Thanks, ...
4 years, 8 months ago (2016-04-06 17:46:35 UTC) #2
gone
lgtm
4 years, 8 months ago (2016-04-06 18:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866033002/1
4 years, 8 months ago (2016-04-06 19:57:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 20:04:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:05:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59a92a51fe90d2ab15d05ed8caaae769b2c2e13a
Cr-Commit-Position: refs/heads/master@{#385534}

Powered by Google App Engine
This is Rietveld 408576698