Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1866023002: [Android] Handle null values in BuildInfo. (Closed)

Created:
4 years, 8 months ago by Bernhard Bauer
Modified:
4 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, pauljensen, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Handle null values in BuildInfo. In some emulator environments, BuildInfo constants can be null. BUG=601081 Committed: https://crrev.com/442dab7d080bd180f1aa70da966c78eedd7e4c88 Cr-Commit-Position: refs/heads/master@{#385509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/android/build_info.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 8 months ago (2016-04-06 17:24:51 UTC) #2
Torne
lgtm
4 years, 8 months ago (2016-04-06 17:44:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866023002/1
4 years, 8 months ago (2016-04-06 18:01:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 18:42:20 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 18:44:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442dab7d080bd180f1aa70da966c78eedd7e4c88
Cr-Commit-Position: refs/heads/master@{#385509}

Powered by Google App Engine
This is Rietveld 408576698