Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 18660012: IndexedDB: Test for "close" event when connection is force-closed. (Closed)

Created:
7 years, 5 months ago by jsbell
Modified:
7 years, 5 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

IndexedDB: Test for "close" event when connection is force-closed. The event is implemented in Blink in http://crrev.com/18042007 - this is just test. BUG=249470 R=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211444

Patch Set 1 #

Patch Set 2 : More context simplification #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 3 chunks +21 lines, -12 lines 2 comments Download
A + content/test/data/indexeddb/force_close_event.html View 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/indexeddb/force_close_event.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
dgrogan@ - take a look?
7 years, 5 months ago (2013-07-11 00:10:16 UTC) #1
jsbell
https://codereview.chromium.org/18660012/diff/2001/content/browser/indexed_db/indexed_db_browsertest.cc File content/browser/indexed_db/indexed_db_browsertest.cc (left): https://codereview.chromium.org/18660012/diff/2001/content/browser/indexed_db/indexed_db_browsertest.cc#oldcode238 content/browser/indexed_db/indexed_db_browsertest.cc:238: IndexedDBContextImpl* context_impl = Unrelated simplification. https://codereview.chromium.org/18660012/diff/2001/content/browser/indexed_db/indexed_db_browsertest.cc#oldcode347 content/browser/indexed_db/indexed_db_browsertest.cc:347: scoped_refptr<IndexedDBContext> context ...
7 years, 5 months ago (2013-07-11 00:17:09 UTC) #2
dgrogan
lgtm
7 years, 5 months ago (2013-07-11 00:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18660012/2001
7 years, 5 months ago (2013-07-12 16:58:37 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 19:36:20 UTC) #5
Message was sent while issue was closed.
Change committed as 211444

Powered by Google App Engine
This is Rietveld 408576698