Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 18660004: Extension activity log database refactoring (step 1) (Closed) Base URL: http://git.chromium.org/chromium/src.git@incognito-tests
Patch Set: Delegate renaming and comment cleanup Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
index 19db2060176bfb6b402166993fb2e380bbc58138..0028eaac3cc8fd6bc1e1b35b594755eaeca45b86 100644
--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
@@ -89,7 +89,7 @@ class FullStreamUIPolicyTest : public testing::Test {
};
TEST_F(FullStreamUIPolicyTest, Construct) {
- scoped_ptr<ActivityLogPolicy> policy(new FullStreamUIPolicy(profile_.get()));
+ ActivityLogPolicy* policy = new FullStreamUIPolicy(profile_.get());
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetManifest(DictionaryBuilder()
@@ -101,10 +101,11 @@ TEST_F(FullStreamUIPolicyTest, Construct) {
scoped_ptr<base::ListValue> args(new base::ListValue());
policy->ProcessAction(ActivityLogPolicy::ACTION_API, extension->id(),
std::string("tabs.testMethod"), GURL(), args.get(), NULL);
+ policy->Close();
}
TEST_F(FullStreamUIPolicyTest, LogAndFetchActions) {
- scoped_ptr<ActivityLogPolicy> policy(new FullStreamUIPolicy(profile_.get()));
+ ActivityLogPolicy* policy = new FullStreamUIPolicy(profile_.get());
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetManifest(DictionaryBuilder()
@@ -124,10 +125,12 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchActions) {
gurl, args.get(), NULL);
policy->ReadData(extension->id(), 0,
base::Bind(FullStreamUIPolicyTest::RetrieveActions_LogAndFetchActions));
+
+ policy->Close();
}
TEST_F(FullStreamUIPolicyTest, LogWithArguments) {
- scoped_ptr<ActivityLogPolicy> policy(new FullStreamUIPolicy(profile_.get()));
+ ActivityLogPolicy* policy = new FullStreamUIPolicy(profile_.get());
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetManifest(DictionaryBuilder()
@@ -143,6 +146,7 @@ TEST_F(FullStreamUIPolicyTest, LogWithArguments) {
std::string("extension.connect"), GURL(), args.get(), NULL);
policy->ReadData(extension->id(), 0,
base::Bind(FullStreamUIPolicyTest::Arguments_Present));
+ policy->Close();
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698